You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2022/11/18 09:46:37 UTC

[GitHub] [ambari-metrics] lucasbak opened a new pull request, #75: Fix Build failure

lucasbak opened a new pull request, #75:
URL: https://github.com/apache/ambari-metrics/pull/75

   ## What changes were proposed in this pull request?
   
   Fix syntax, refactor and versions and make `mvn package`  build pass
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330070573

   +1, test successful in centos7 following `mvn clean install -DskipTests`.
   ![1669696945061](https://user-images.githubusercontent.com/16263438/204440787-9927c882-67c9-4888-9cda-acdbbafe5261.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330487346

   
   
   
   
   > @timyuer it's because you need to specify which release it is. For example for releasing 2.7.0.0 It's from rpm-maven-plugin
   > 
   > ```shell
   > mvn clean install rpm:rpm -Dpackage-release=2.7.7 -DskipTests`
   > ```
   
   @lucasbak 
   
   This is a temporary solution, but its default `package-release`  in `pom.xml` seems to have a problem, which needs to be fixed.
   And the version for ambari-metrics is `2.0.0.0-SNAPSHOT`.
   ![1669721465724](https://user-images.githubusercontent.com/16263438/204518038-ca56dd5a-a678-40de-b17d-37c99d04d0b7.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328091417

   thanks for the review @timyuer
   in which format should I add the license ?
   the [![License](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) badge is in the README.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330504350

   
   It comes from the parse-package-release id plugin
   ```
   regex: ^([0-9]+)\.([0-9]+)\.([0-9]+)\.([0-9]+)(\.|-)((([a-zA-Z]+)?([0-9]+))|(SNAPSHOT)).*
   version: 2.0.0.0-SNAPSHOT
   replacement: $7 
   ```
   @timyuer I propose we replace the regex by `^([0-9]+)\.([0-9]+)\.([0-9]+)\.([0-9]+)((\.|-)(([0-9]+)|(SNAPSHOT)|(techwin)).*)?` as in `Ambari`.
   so replacement $7 matches the release (Snapshot here)
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] virajjasani commented on a diff in pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
virajjasani commented on code in PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#discussion_r1031984574


##########
pom.xml:
##########
@@ -37,14 +37,14 @@
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <python.ver>python &gt;= 2.6</python.ver>
     <deb.python.ver>python (&gt;= 2.6)</deb.python.ver>
-    <!--TODO change to HDP URL-->
+    <slf4j.version>2.0.0</slf4j.version>
     <hbase.tar>https://archive.apache.org/dist/hbase/2.4.2/hbase-2.4.2-bin.tar.gz</hbase.tar>
     <hbase.folder>hbase-2.4.2</hbase.folder>
     <hadoop.tar>https://archive.apache.org/dist/hadoop/common/hadoop-3.1.1/hadoop-3.1.1.tar.gz</hadoop.tar>
     <hadoop.folder>hadoop-3.1.1</hadoop.folder>
     <hadoop.version>3.1.1</hadoop.version>
-    <grafana.folder>grafana-5.2.4</grafana.folder>
-    <grafana.tar>https://s3-us-west-2.amazonaws.com/grafana-releases/release/grafana-5.2.4.linux-amd64.tar.gz</grafana.tar>
+    <grafana.folder>grafana-6.7.4</grafana.folder>
+    <grafana.tar>https://dl.grafana.com/oss/release/grafana-6.7.4.linux-amd64.tar.gz</grafana.tar>

Review Comment:
   I am not aware of how we can fetch grafana tarball, other than that, changes look good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330627068

   For the version, the 2.1.4 in `pom.xml` comes from commit forwarding, we can set `2.1.4` everywhere


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328003605

   `README.md` and `.github/pull_request_template.md` didn't  contain Lincese, This will not pass the RAT check.
   @lucasbak 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330473563

   @timyuer it's because you need to specify which release it is.
   For example for releasing 2.7.0.0
   It's from rpm-maven-plugin
   ```bash
   mvn clean install rpm:rpm -Dpackage-release=2.7.7 -DskipTests`
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330529934

   > 
   
   The compilation still fails after the above operations are performed.
   Then I found that the version of `rpm-maven-plugin` is not consistent. Is it caused by this problem?
   ```
   [INFO] Creating empty directory /opt/package/code/ambari-metrics/ambari-metrics-timelineservice/target/rpm/ambari-metrics-collector/buildroot/var/lib/ambari-metrics-collector
   [INFO] Creating spec file /opt/package/code/ambari-metrics/ambari-metrics-timelineservice/target/rpm/ambari-metrics-collector/SPECS/ambari-metrics-collector.spec
   [WARNING] error: License field must be present in package: (main package)
   [INFO] Building target platforms: noarch-redhat-linux
   [INFO] Building for target noarch-redhat-linux
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary for ambari-metrics 2.0.0.0-SNAPSHOT:
   [INFO] 
   [INFO] ambari-metrics ..................................... SUCCESS [  8.346 s]
   [INFO] Ambari Metrics Common .............................. SUCCESS [ 15.320 s]
   [INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [  8.041 s]
   [INFO] Ambari Metrics Flume Sink .......................... SUCCESS [  3.666 s]
   [INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [  4.242 s]
   [INFO] Ambari Metrics Storm Sink .......................... SUCCESS [  3.506 s]
   [INFO] Ambari Metrics Collector ........................... FAILURE [ 54.423 s]
   [INFO] Ambari Metrics Monitor ............................. SKIPPED
   [INFO] Ambari Metrics Grafana ............................. SKIPPED
   [INFO] Ambari Metrics Host Aggregator ..................... SKIPPED
   [INFO] Ambari Metrics Assembly ............................ SKIPPED
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  01:38 min
   [INFO] Finished at: 2022-11-29T19:54:28+08:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.0.1:rpm (default-cli) on project ambari-metrics-timelineservice: RPM build execution returned: '1' executing '/bin/sh -c cd /opt/package/code/ambari-metrics/ambari-metrics-timelineservice/target/rpm/ambari-metrics-collector/SPECS && rpmbuild -bb --buildroot /opt/package/code/ambari-metrics/ambari-metrics-timelineservice/target/rpm/ambari-metrics-collector/buildroot --define '_topdir /opt/package/code/ambari-metrics/ambari-metrics-timelineservice/target/rpm/ambari-metrics-collector' --target noarch-redhat-linux ambari-metrics-collector.spec' -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
   [ERROR] 
   [ERROR] After correcting the problems, you can resume the build with the command
   [ERROR]   mvn <args> -rf :ambari-metrics-timelineservice
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] kevinw66 commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1336165401

   Thanks @lucasbak , compilation succeed now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328131164

   > thanks for the review @timyuer in which format should I add the license ? the [![License](https://camo.githubusercontent.com/684b80de8a7f9f15265f05513c5a770c2051df7278a2376368d2b489eba3efcc/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f4c6963656e73652d4170616368655f322e302d626c75652e737667)](https://opensource.org/licenses/Apache-2.0) badge is in the README.md
   
   @lucasbak 
   
   Like this
   ![1669505214420](https://user-images.githubusercontent.com/16263438/204112533-888121b9-53f6-475e-84be-e11ce3c7d8ea.png)
   
    in https://github.com/apache/ambari/blob/trunk/README.md?plain=1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] kevinw66 commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1327313517

   There are conflicts after merge #76 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] kevinw66 merged pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] lucasbak commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
lucasbak commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1328342958

   @timyuer  thanks for the example, I have added in both files the Apache License 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org

[GitHub] [ambari-metrics] timyuer commented on pull request #75: AMBARI-25782: Fix syntax, refactor and versions after forwarding from Ambari to ambari-metrics

Posted by GitBox <gi...@apache.org>.
timyuer commented on PR #75:
URL: https://github.com/apache/ambari-metrics/pull/75#issuecomment-1330443223

   @lucasbak 
   Fail to execute `mvn clean install rpm:rpm -DskipTests` in Centos7.
   
   ```bash
   [INFO] --- rpm-maven-plugin:2.1.4:rpm (default-cli) @ ambari-metrics ---
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/BUILD
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/RPMS
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/SOURCES
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/SPECS
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/SRPMS
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/tmp-buildroot
   [INFO] Creating directory /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/buildroot
   [INFO] Creating spec file /opt/package/code/ambari-metrics/target/rpm/ambari-metrics/SPECS/ambari-metrics.spec
   [INFO] error: line 4: Empty tag: Release:
   [INFO] Building target platforms: noarch-redhat-linux
   [INFO] Building for target noarch-redhat-linux
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary for ambari-metrics 2.0.0.0-SNAPSHOT:
   [INFO] 
   [INFO] ambari-metrics ..................................... FAILURE [  2.522 s]
   [INFO] Ambari Metrics Common .............................. SKIPPED
   [INFO] Ambari Metrics Hadoop Sink ......................... SKIPPED
   [INFO] Ambari Metrics Flume Sink .......................... SKIPPED
   [INFO] Ambari Metrics Kafka Sink .......................... SKIPPED
   [INFO] Ambari Metrics Storm Sink .......................... SKIPPED
   [INFO] Ambari Metrics Collector ........................... SKIPPED
   [INFO] Ambari Metrics Monitor ............................. SKIPPED
   [INFO] Ambari Metrics Grafana ............................. SKIPPED
   [INFO] Ambari Metrics Host Aggregator ..................... SKIPPED
   [INFO] Ambari Metrics Assembly ............................ SKIPPED
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  2.965 s
   [INFO] Finished at: 2022-11-29T13:12:56+08:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.4:rpm (default-cli) on project ambari-metrics: RPM build execution returned: '1' executing '/bin/sh -c cd '/opt/package/code/ambari-metrics/target/rpm/ambari-metrics/SPECS' && 'rpmbuild' '-bb' '--target' 'noarch-redhat-linux' '--buildroot' '/opt/package/code/ambari-metrics/target/rpm/ambari-metrics/buildroot' '--define' '_topdir /opt/package/code/ambari-metrics/target/rpm/ambari-metrics' '--define' '_build_name_fmt %%{ARCH}/%%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm' '--define' '_builddir %{_topdir}/BUILD' '--define' '_rpmdir %{_topdir}/RPMS' '--define' '_sourcedir %{_topdir}/SOURCES' '--define' '_specdir %{_topdir}/SPECS' '--define' '_srcrpmdir %{_topdir}/SRPMS' 'ambari-metrics.spec'' -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org