You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/20 16:58:13 UTC

[GitHub] [solr] dsmiley opened a new pull request #84: SOLR-15356: MergeIndexes should not use UninvertingReader.

dsmiley opened a new pull request #84:
URL: https://github.com/apache/solr/pull/84


   Also change some tests to avoid Lucene's new FieldInfo consistency checks in LUCENE-9334
   
   https://issues.apache.org/jira/browse/SOLR-15356
   
   I'm not sure if there's a valid use-case for addIndexes/merge to use UninvertingReader like some sort of non-docValues to getting docValues migration?  If that would work (not even sure), it would require merging into an empty index to keep the FieldInfo's consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley merged pull request #84: SOLR-15356: MergeIndexes should not use UninvertingReader.

Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #84:
URL: https://github.com/apache/solr/pull/84


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on a change in pull request #84: SOLR-15356: MergeIndexes should not use UninvertingReader.

Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #84:
URL: https://github.com/apache/solr/pull/84#discussion_r617075120



##########
File path: solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java
##########
@@ -1765,22 +1765,24 @@ public void testRealtimeGet() throws Exception
   @Test
   public void testUpdateField() throws Exception {
     //no versions
+    // Use a simple float field.  "price"->"price_c" has problems: SOLR-15357 & SOLR-15358
+    final String field = "price_f";

Review comment:
       @madrob maybe you are interested in this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org