You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/01/07 22:43:54 UTC

Review Request 42035: Windows: Remove the `--switch_user` flag in Windows.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/
-----------------------------------------------------------

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and Joris Van Remoortere.


Bugs: MESOS-4310
    https://issues.apache.org/jira/browse/MESOS-4310


Repository: mesos


Description
-------

The Mesos agent provides a flag, `--[no-]switch_user`, which instructs
the agent to run tasks as the user who submitted the task instead of the
user that is running the agent process itself.

On POSIX, this requires the usual suspects (`su`, `chown`, and `chroot`,
for example to do things like make sure the correct user owns the
executor directory, and things like that.

On Windows, many of these operations have very different semantics. To
use one example, to `chown` on Windows, you normally have to give
*permission* for something to `chown` an object, and then that thing
actually has to use that permission to `chown` it, on its own.

Clearly a semantic mismatch of this magnitude will require some work to
formally bridge, and the result is that we will simply disable the
functionality entirely on the Windows agent until we are prepared to go
back and support it formally.


Diffs
-----

  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
  src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 

Diff: https://reviews.apache.org/r/42035/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42035/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 9:44 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, and Joris Van Remoortere.


Summary (updated)
-----------------

Windows: Removed the `--switch_user` flag in Windows.


Bugs: MESOS-4310
    https://issues.apache.org/jira/browse/MESOS-4310


Repository: mesos


Description
-------

The Mesos agent provides a flag, `--[no-]switch_user`, which instructs
the agent to run tasks as the user who submitted the task instead of the
user that is running the agent process itself.

On POSIX, this requires the usual suspects (`su`, `chown`, and `chroot`,
for example to do things like make sure the correct user owns the
executor directory, and things like that.

On Windows, many of these operations have very different semantics. To
use one example, to `chown` on Windows, you normally have to give
*permission* for something to `chown` an object, and then that thing
actually has to use that permission to `chown` it, on its own.

Clearly a semantic mismatch of this magnitude will require some work to
formally bridge, and the result is that we will simply disable the
functionality entirely on the Windows agent until we are prepared to go
back and support it formally.


Diffs (updated)
-----

  docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 
  src/slave/flags.hpp 6857fde027fd57b4934cb43ddf435d12900e0b87 
  src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 

Diff: https://reviews.apache.org/r/42035/diff/


Testing
-------


Thanks,

Alex Clemmer