[GitHub] [logging-log4j2] srdo edited a comment on pull request #644: LOG4J2-3259: Limit max recursion depth when interpolating strings.

[GitBox <gi...@apache.org>]

srdo edited a comment on pull request #644:
URL: https://github.com/apache/logging-log4j2/pull/644#issuecomment-1001000089


   > Should we return the input, or the pieces that we could successfully replace
   
   Neither string is likely to be the output the author wanted I think. If this case is hit, the person monitoring the logs should become aware that there is a bug to fix, due to the status logger. I'm not sure if it makes a great difference which of the wrong log outputs they get back?
   
   A minor benefit of returning the original string is that it might be easier to grep for?
   
   The note about try-catching makes sense, I could add a try-catch to `substitute` so it is not possible to forget to handle the exception?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org