You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/09/21 17:18:07 UTC
[GitHub] [ignite] Vladsz83 opened a new pull request, #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Vladsz83 opened a new pull request, #10262:
URL: https://github.com/apache/ignite/pull/10262
Limited max parallel batches for a node. The limitation now looks at cache persistence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Posted by GitBox <gi...@apache.org>.
ivandasch commented on code in PR #10262:
URL: https://github.com/apache/ignite/pull/10262#discussion_r983338699
##########
modules/core/src/main/java/org/apache/ignite/stream/StreamReceiver.java:
##########
@@ -41,4 +43,18 @@
* @throws org.apache.ignite.IgniteException If failed.
*/
public void receive(IgniteCache<K, V> cache, Collection<Map.Entry<K, V>> entries) throws IgniteException;
+
+ /**
+ * Sets max parallel batches (operations) per node if {@link IgniteDataStreamer#perNodeParallelOperations()} is not
+ * positive. In same way takes place only if positive.
+ *
+ * @param node Node to send to.
+ * @param persistant {@code True} if the cache is persistent. {@code False} otherwise.
+ *
+ * @return Max parallel batches.
+ * @see IgniteDataStreamer#perNodeParallelOperations(int)
+ */
+ public default int perNodeParallelOperations(ClusterNode node, boolean persistant) {
Review Comment:
persist**e**nt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ivandasch commented on a diff in pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Posted by GitBox <gi...@apache.org>.
ivandasch commented on code in PR #10262:
URL: https://github.com/apache/ignite/pull/10262#discussion_r983338699
##########
modules/core/src/main/java/org/apache/ignite/stream/StreamReceiver.java:
##########
@@ -41,4 +43,18 @@
* @throws org.apache.ignite.IgniteException If failed.
*/
public void receive(IgniteCache<K, V> cache, Collection<Map.Entry<K, V>> entries) throws IgniteException;
+
+ /**
+ * Sets max parallel batches (operations) per node if {@link IgniteDataStreamer#perNodeParallelOperations()} is not
+ * positive. In same way takes place only if positive.
+ *
+ * @param node Node to send to.
+ * @param persistant {@code True} if the cache is persistent. {@code False} otherwise.
+ *
+ * @return Max parallel batches.
+ * @see IgniteDataStreamer#perNodeParallelOperations(int)
+ */
+ public default int perNodeParallelOperations(ClusterNode node, boolean persistant) {
Review Comment:
persist*e*nt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on PR #10262:
URL: https://github.com/apache/ignite/pull/10262#issuecomment-1293874304
Other, simplier impls: https://github.com/apache/ignite/pull/10343 or https://github.com/apache/ignite/pull/10351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 closed pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Posted by GitBox <gi...@apache.org>.
Vladsz83 closed pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
URL: https://github.com/apache/ignite/pull/10262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a diff in pull request #10262: IGNITE-17735 : Datastreamer may consume whole heap.
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on code in PR #10262:
URL: https://github.com/apache/ignite/pull/10262#discussion_r983397201
##########
modules/core/src/main/java/org/apache/ignite/stream/StreamReceiver.java:
##########
@@ -41,4 +43,18 @@
* @throws org.apache.ignite.IgniteException If failed.
*/
public void receive(IgniteCache<K, V> cache, Collection<Map.Entry<K, V>> entries) throws IgniteException;
+
+ /**
+ * Sets max parallel batches (operations) per node if {@link IgniteDataStreamer#perNodeParallelOperations()} is not
+ * positive. In same way takes place only if positive.
+ *
+ * @param node Node to send to.
+ * @param persistant {@code True} if the cache is persistent. {@code False} otherwise.
+ *
+ * @return Max parallel batches.
+ * @see IgniteDataStreamer#perNodeParallelOperations(int)
+ */
+ public default int perNodeParallelOperations(ClusterNode node, boolean persistant) {
Review Comment:
Fixed. In other places too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org