You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/29 22:25:46 UTC

[GitHub] [spark] ylybest opened a new pull request, #38843: SPARK-41327 Fix SparkStatusTracker.getExecutorInfos by switch On/OffH…

ylybest opened a new pull request, #38843:
URL: https://github.com/apache/spark/pull/38843

   https://issues.apache.org/jira/browse/SPARK-41327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #38843: [SPARK-41327][CORE] Fix SparkStatusTracker.getExecutorInfos by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1331425834

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1332180177

   Please re-trigger the failed GA task @ylybest 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ylybest commented on pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
ylybest commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1331450278

   > Thank you for making a contribution, @ylybest .
   > 
   > I added you to the Apache Spark contributor group.
   
   Thanks a lot @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ylybest commented on a diff in pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
ylybest commented on code in PR #38843:
URL: https://github.com/apache/spark/pull/38843#discussion_r1035373725


##########
core/src/main/scala/org/apache/spark/SparkStatusTracker.scala:
##########
@@ -100,7 +100,7 @@ class SparkStatusTracker private[spark] (sc: SparkContext, store: AppStatusStore
   /**
    * Returns information of all known executors, including host, port, cacheSize, numRunningTasks
    * and memory metrics.
-   * Note this include information for both the driver and executors.
+   * Note this include information for both the driver and executors. 

Review Comment:
   revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info
URL: https://github.com/apache/spark/pull/38843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1332494831

   Thank you, @mridulm , @Ngone51 , @LuciferYang .
   @ylybest re-triggered the failed pipeline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38843:
URL: https://github.com/apache/spark/pull/38843#discussion_r1035372076


##########
core/src/main/scala/org/apache/spark/SparkStatusTracker.scala:
##########
@@ -100,7 +100,7 @@ class SparkStatusTracker private[spark] (sc: SparkContext, store: AppStatusStore
   /**
    * Returns information of all known executors, including host, port, cacheSize, numRunningTasks
    * and memory metrics.
-   * Note this include information for both the driver and executors.
+   * Note this include information for both the driver and executors. 

Review Comment:
   Could you revert this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1332656635

   All tests passed. Merged to master/3.3/3.2.
   
   ![Screen Shot 2022-11-30 at 11 42 28 AM](https://user-images.githubusercontent.com/9700541/204893171-03c89ff9-55fd-496a-8b44-b1ecb871d38a.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #38843: [SPARK-41327][CORE] Fix `SparkStatusTracker.getExecutorInfos` by switch On/OffHeapStorageMemory info

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38843:
URL: https://github.com/apache/spark/pull/38843#issuecomment-1332655935

   Thank you, @attilapiros !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org