You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2015/09/28 22:37:06 UTC

[jira] [Comment Edited] (TEZ-2836) Avoid setting framework/system counters for tasks running in threads

    [ https://issues.apache.org/jira/browse/TEZ-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933935#comment-14933935 ] 

Siddharth Seth edited comment on TEZ-2836 at 9/28/15 8:37 PM:
--------------------------------------------------------------

Thanks for the review. Updated patch which removes the boolean parameter.
However, I don't want to rely on the numTaskCountesr >= minTaskCounters condition since that will be true for 0 or more counters when the expected count is 0. Instead - have modified the patch to check for exactly 0 if expCount is set to 0 or -1.
Will commit after jenkins gets back.


was (Author: sseth):
Thanks for the review. Updated patch which removes the boolean parameter.
However, I don't want to rely on the numTaskCountesr >= minTaskCounters condition since that will be true for 0 or more counters when the expected count is 0. Instead - have modified the patch to check for exactly 0 if expCount is set to 0 or -1.

> Avoid setting framework/system counters for tasks running in threads
> --------------------------------------------------------------------
>
>                 Key: TEZ-2836
>                 URL: https://issues.apache.org/jira/browse/TEZ-2836
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-2836.1.txt, TEZ-2836.2.txt
>
>
> Counters like FileSystemCounters, GC_TIME, CPU_TIME etc - are computed incorrectly in case of LocalMode, Uber, TestService and others where tasks may execute in threads. (The values end up being a combination of what's running in the process - which could be other tasks or the AM).
> It's better not to set them for now, instead of reporting incorrect values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)