You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by audreyso <gi...@git.apache.org> on 2017/07/20 18:33:59 UTC
[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/580
CB-12895 : Replaced jshint with eslint
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Replaced jshint with eslint
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12895-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #580
----
commit 4cb49cf58523d0ef8039cba6b2d3d6a7ebc260a9
Author: Audrey So <au...@apache.org>
Date: 2017-07-19T16:51:05Z
CB-12895 : set up eslint
commit 25c80f56f2697f6f359669eb8e150b208e2cd9f2
Author: Audrey So <au...@apache.org>
Date: 2017-07-19T16:54:49Z
CB-12895 : ran eslint --fix on cordova-lib
commit 55a3eccf913ac0cee11633718a11748a43e8cb88
Author: Audrey So <au...@apache.org>
Date: 2017-07-20T16:41:06Z
CB-12895 : updated integration tests with eslint
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #580: CB-12895 : Replaced jshint with eslint
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #580: CB-12895 : Replaced jshint with eslint
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/580
Huge PR! haha LGTM. I did a quick scan. Looks like spacing formatting for the most part. A few unused vars that you added exceptions for.
Merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org