You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@zipkin.apache.org by GitBox <gi...@apache.org> on 2019/05/18 07:38:17 UTC

[GitHub] [incubator-zipkin] trustin commented on a change in pull request #2604: Moves to Armeria 0.86

trustin commented on a change in pull request #2604: Moves to Armeria 0.86
URL: https://github.com/apache/incubator-zipkin/pull/2604#discussion_r285332803
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -213,7 +214,7 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage
     String encoding = request.headers().get(HttpHeaderNames.CONTENT_ENCODING);
     HttpData content = request.content();
     if (!content.isEmpty() && encoding != null && encoding.contains("gzip")) {
-      content = GZIP_DECODER_FACTORY.newDecoder().decode(content);
+      content = GZIP_DECODER_FACTORY.newDecoder(ByteBufAllocator.DEFAULT).decode(content);
 
 Review comment:
   You can use ctx.alloc() 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services