[GitHub] [iceberg] shardulm94 commented on a change in pull request #1254: Parquet: Add row position reader

[GitBox <gi...@apache.org>]

shardulm94 commented on a change in pull request #1254:
URL: https://github.com/apache/iceberg/pull/1254#discussion_r461150177



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java
##########
@@ -137,6 +137,41 @@ public void setPageSource(PageReadStore pageStore) {
     }
   }
 
+  static class PositionReader implements ParquetValueReader<Long> {
+    private long rowOffsetInCurrentRowGroup = -1;
+    private long rowGroupRowOffsetInfile;

Review comment:
       Nit: Should be `rowGroupRowOffsetInFile` to maintain consistent camel casing in the variable name.
        




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org