You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/03/05 17:34:08 UTC
[kudu-CR] python3 support for build
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9492
to review the following change.
Change subject: python3 support for build
......................................................................
python3 support for build
makes gen_version_info.py and kudu_util.py python3 as well as python2 compliant.
Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
---
M build-support/gen_version_info.py
M build-support/kudu_util.py
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/9492/1
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
[kudu-CR] python3 support for build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 17:40:54 +0000
Gerrit-HasComments: No
[kudu-CR] python3 support for build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@35
PS2, Line 35: from __future__ import print_function
Where is this used?
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:29:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for build
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@35
PS2, Line 35: from __future__ import print_function
> Where is this used?
It's necessary to get the 'file=sys.stderr' support for 'print'.
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:31:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@35
PS2, Line 35: from __future__ import print_function
> Where is this used?
I was just googling this to understand it a bit more. https://docs.python.org/2/reference/simple_stmts.html#future
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:31:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for build
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9492
to look at the new patch set (#2).
Change subject: python3 support for build
......................................................................
python3 support for build
Adds python3 support to gen_version_info.py, kudu_util.py, and
push_to_asf.py while maintaining python2 compatibility.
Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
---
M build-support/gen_version_info.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
3 files changed, 39 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/9492/2
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python3 support for build
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:33:28 +0000
Gerrit-HasComments: No
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py@86
PS3, Line 86: print("the contributor guide (git remote add gerrit %s)." % GERRIT_URL, file=sys.stderr)
> Mind breaking this out into a separate patch? I know it's tiny but I think
Done
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:43:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py@86
PS3, Line 86: print("the contributor guide (git remote add gerrit %s)." % GERRIT_URL, file=sys.stderr)
> Mind breaking this out into a separate patch? I know it's tiny but I think
This is Python3 compatibility as is: 'rint >>' construct does not work in Python3.
Or the idea is to separate build-related and aux stuff?
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:36:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:50:34 +0000
Gerrit-HasComments: No
[kudu-CR] python3 support for build
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@35
PS2, Line 35: from __future__ import print_function
> I was just googling this to understand it a bit more. https://docs.python.o
Oh, I didn't bother googling so I assumed that, like any import, "print_function" should be referenced literally in the code somewhere. Makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:39:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 4: Verified+1
failure appears to be an unrelated flake
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 20:28:34 +0000
Gerrit-HasComments: No
[kudu-CR] python3 support for build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py
File build-support/gen_version_info.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py@23
PS2, Line 23: import hashlib
> Does it work for python 2.7?
Some time ago I looked at that as well:
https://gerrit.cloudera.org/#/c/8353
It seemed to me that it was necessary to do something like the following to make it work for python 2.6/2.7:
try:
from hashlib import sha1
except:
from sha import sha as sha1
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:39:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py@86
PS3, Line 86: sys.exit(1)
> This is Python3 compatibility as is: 'rint >>' construct does not work in P
Ah, sorry -- it seems I confused the location for this comment.
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:43:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9492
to look at the new patch set (#4).
Change subject: python3 support for some build tools
......................................................................
python3 support for some build tools
Adds python3 support to the following files while retaining python2 compatibility:
- gen_version_info.py
- kudu_util.py,
- push_to_asf.py
Some python build tools are still known not to be python3 compatible,
including:
- build_source_release.py
- dist_test.py
- trigger_gerrit.py.
These haven't been fixed either because they use urllib, which I can't
figure out how to make 2 and 3 compatible, or because I don't have a
dist-test compatible system with python 3 available.
Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
---
M build-support/build_source_release.py
M build-support/gen_version_info.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
4 files changed, 84 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/9492/4
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python3 support for some build tools
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/3/build-support/push_to_asf.py@86
PS3, Line 86: print("the contributor guide (git remote add gerrit %s)." % GERRIT_URL, file=sys.stderr)
Mind breaking this out into a separate patch? I know it's tiny but I think it'd be good if this patch were JUST about Python 3 compatibility issues.
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:33:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9492
to look at the new patch set (#3).
Change subject: python3 support for some build tools
......................................................................
python3 support for some build tools
Adds python3 support to the following files while retaining python2 compatibility:
- gen_version_info.py
- kudu_util.py,
- push_to_asf.py
Some python build tools are still known not to be python3 compatible,
including:
- build_source_release.py
- dist_test.py
- trigger_gerrit.py.
These haven't been fixed either because they use urllib, which I can't
figure out how to make 2 and 3 compatible, or because I don't have a
dist-test compatible system with python 3 available.
Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
---
M build-support/build_source_release.py
M build-support/gen_version_info.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
4 files changed, 85 insertions(+), 74 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/9492/3
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python3 support for build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@83
PS2, Line 83: except subprocess.CalledProcessError:
: print >>sys.stderr, "No remote named 'gerrit'. Please set one up following "
: print >>sys.stderr, "the contributor guide."
: sys.exit(1)
: if not GERRIT_URL_RE.match(url):
: print >>sys.stderr, "Unexpected URL for remote 'gerrit'."
: print >>sys.stderr, " Got: ", url
: print >>sys.stderr, " Expected to find host '%s' in the URL" % GERRIT_HOST
Does this work in python3?
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:43:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has removed a vote on this change.
Change subject: python3 support for some build tools
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py
File build-support/gen_version_info.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py@23
PS2, Line 23: import hashlib
> Some time ago I looked at that as well:
Yeah, it appears to work on my system's 2.6 and 2.7.
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py
File build-support/push_to_asf.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/push_to_asf.py@83
PS2, Line 83: except subprocess.CalledProcessError:
: print >>sys.stderr, "No remote named 'gerrit'. Please set one up following "
: print >>sys.stderr, "the contributor guide."
: sys.exit(1)
: if not GERRIT_URL_RE.match(url):
: print >>sys.stderr, "Unexpected URL for remote 'gerrit'."
: print >>sys.stderr, " Got: ", url
: print >>sys.stderr, " Expected to find host '%s' in the URL" % GERRIT_HOST
> Does this work in python3?
nope, good catch.
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:28:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:52:11 +0000
Gerrit-HasComments: No
[kudu-CR] python3 support for build
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for build
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py
File build-support/gen_version_info.py:
http://gerrit.cloudera.org:8080/#/c/9492/2/build-support/gen_version_info.py@23
PS2, Line 23: import hashlib
Does it work for python 2.7?
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:37:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] python3 support for some build tools
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9492 )
Change subject: python3 support for some build tools
......................................................................
python3 support for some build tools
Adds python3 support to the following files while retaining python2 compatibility:
- gen_version_info.py
- kudu_util.py,
- push_to_asf.py
Some python build tools are still known not to be python3 compatible,
including:
- build_source_release.py
- dist_test.py
- trigger_gerrit.py.
These haven't been fixed either because they use urllib, which I can't
figure out how to make 2 and 3 compatible, or because I don't have a
dist-test compatible system with python 3 available.
Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Reviewed-on: http://gerrit.cloudera.org:8080/9492
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Dan Burkert <da...@apache.org>
---
M build-support/build_source_release.py
M build-support/gen_version_info.py
M build-support/kudu_util.py
M build-support/push_to_asf.py
4 files changed, 84 insertions(+), 74 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Dan Burkert: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I547d870a54c7d396d2706d63f65844df01ff7c57
Gerrit-Change-Number: 9492
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins