You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by nonstop-qfchen <gi...@git.apache.org> on 2015/07/08 21:51:20 UTC
[GitHub] incubator-trafodion pull request: fix TRAFODION-21 and updated the...
GitHub user nonstop-qfchen opened a pull request:
https://github.com/apache/incubator-trafodion/pull/22
fix TRAFODION-21 and updated the known diff for qatdml04.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nonstop-qfchen/incubator-trafodion cg-test042
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit 3a822f2fd32c64d764fb12b712c7e3532a3bb591
Author: Qifan Chen <qf...@dev02.trafodion.org>
Date: 2015-07-08T19:34:03Z
fix TRAFODION-21 and updated the known diff for qatdml04.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-21 and updated the...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/22#discussion_r34194458
--- Diff: core/sql/regress/qat/dqatdml04.known ---
@@ -1,32 +1,12 @@
-2571a2572
-> >>?ignore
-2576,2588d2576
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2100.00
-< 10000 2100.00
-< 16000 1300.00
-< 16000 2100.00
-< 18000 1600.00
-< 20000 300.00
-< 20000 2100.00
-<
-< --- 7 row(s) selected.
-2595,2607c2583
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2000.000
-< 10000 2000.000
-< 16000 1200.000
-< 16000 2000.000
-< 18000 1500.000
-< 20000 200.000
-< 20000 2000.000
-<
+2454c2454
+< 100
--- End diff --
This looks like you changed the test also, removing the ?ignore, but the pull request doesn't show a change in the test file. Is that ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-21 and updated the...
Posted by nonstop-qfchen <gi...@git.apache.org>.
Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/22#discussion_r34195946
--- Diff: core/sql/regress/qat/dqatdml04.known ---
@@ -1,32 +1,12 @@
-2571a2572
-> >>?ignore
-2576,2588d2576
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2100.00
-< 10000 2100.00
-< 16000 1300.00
-< 16000 2100.00
-< 18000 1600.00
-< 20000 300.00
-< 20000 2100.00
-<
-< --- 7 row(s) selected.
-2595,2607c2583
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2000.000
-< 10000 2000.000
-< 16000 1200.000
-< 16000 2000.000
-< 18000 1500.000
-< 20000 200.000
-< 20000 2000.000
-<
+2454c2454
+< 100
--- End diff --
Hi Hans,
I did not think I have changed the test. Otherwise, git will pick it up.
I think what really happened is that the old content of the known diff is
not used in recent test. The updated content reflects the new diff.
thanks
2015-07-08 15:29 GMT-05:00 Hans Zeller <no...@github.com>:
> In core/sql/regress/qat/dqatdml04.known
> <https://github.com/apache/incubator-trafodion/pull/22#discussion_r34194458>
> :
>
> > -< --- 7 row(s) selected.
> > -2595,2607c2583
> > -<
> > -< A B
> > -< -------------------- ---------------------
> > -<
> > -< 2000 2000.000
> > -< 10000 2000.000
> > -< 16000 1200.000
> > -< 16000 2000.000
> > -< 18000 1500.000
> > -< 20000 200.000
> > -< 20000 2000.000
> > -<
> > +2454c2454
> > +< 100
>
> This looks like you changed the test also, removing the ?ignore, but the
> pull request doesn't show a change in the test file. Is that ok?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/22/files#r34194458>.
>
--
Regards, --Qifan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: fix TRAFODION-21 and updated the...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/22#discussion_r34200687
--- Diff: core/sql/regress/qat/dqatdml04.known ---
@@ -1,32 +1,12 @@
-2571a2572
-> >>?ignore
-2576,2588d2576
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2100.00
-< 10000 2100.00
-< 16000 1300.00
-< 16000 2100.00
-< 18000 1600.00
-< 20000 300.00
-< 20000 2100.00
-<
-< --- 7 row(s) selected.
-2595,2607c2583
-<
-< A B
-< -------------------- ---------------------
-<
-< 2000 2000.000
-< 10000 2000.000
-< 16000 1200.000
-< 16000 2000.000
-< 18000 1500.000
-< 20000 200.000
-< 20000 2000.000
-<
+2454c2454
+< 100
--- End diff --
Thanks a lot for the explanation, now it makes perfect sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---