You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/09/11 23:16:15 UTC

[GitHub] [arrow] zeroshade commented on a diff in pull request #37637: GH-37636: [Go] Bump minimum go versions

zeroshade commented on code in PR #37637:
URL: https://github.com/apache/arrow/pull/37637#discussion_r1322171314


##########
.github/workflows/go.yml:
##########
@@ -54,23 +54,23 @@ jobs:
         include:
           - arch-label: AMD64
             arch: amd64
-            go: 1.17
+            go: 1.19
             runs-on: ubuntu-latest
-            staticcheck: v0.2.2
+            staticcheck: v0.4.5

Review Comment:
   Yea, we only needed it before because you couldn't use `latest` with go1.17, you had to use v0.2.2, and then we wanted to use the newer versions with go1.18. Now we can use the latest version with go1.19 and go1.20 but instead of using `latest` it's better to actually pin at v0.4.5. I've removed it from the parameters and just explicitly put it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org