You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/07/04 14:32:22 UTC

[GitHub] [arrow-datafusion] tustvold opened a new issue, #6842: Use Specialization Instead of ScalarValue Binary Operations

tustvold opened a new issue, #6842:
URL: https://github.com/apache/arrow-datafusion/issues/6842

   ### Is your feature request related to a problem or challenge?
   
   Currently a number of operations are implemented directly on ScalarValue, including:
   
   * Arithmetic
   * Logical And
   * Logical Or
   * BitAnd, BitXor, etc...
   * Comparison
   
   Not only does this result in a huge amount of code, but also these operations don't behave the same way as their array counterparts.
   
   For example:
   
   * An operation on a null doesn't yield a null
   * Floating point NaNs are not total ordered
   * No support for decimals
   * Differing support for interval arithmetic compared to the array kernels
   
   ### Describe the solution you'd like
   
   These kernels largely appear to exist for the purposes of aggregation, where the aggregated types are known statically. We should replace these uses with specialization, as done in https://github.com/apache/arrow-datafusion/pull/6800#discussion_r1248104156
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   #4973 tracks improving the aggregator performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold commented on issue #6842: Use Specialization Instead of ScalarValue Binary Operations

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #6842:
URL: https://github.com/apache/arrow-datafusion/issues/6842#issuecomment-1713820554

   IIRC there are some aggregates, like first and last that are not yet specialized


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #6842: Use Specialization Instead of ScalarValue Binary Operations

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6842:
URL: https://github.com/apache/arrow-datafusion/issues/6842#issuecomment-1713637194

   I think we have made substantial progress on this issue -- what is let to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org