You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2012/07/31 20:28:42 UTC

Review Request:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6245/
-----------------------------------------------------------

Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.


Description
-------

Basic zone, EIP ELB N/w Offering. 
Unable to create Autoscale policy from UI 
Steps 
===== 

Network -> GuestNetwork -> AddLoadBalancer -> provide name/port -> Autoscale - Configure -> Provide all autoscale configs 

autoscale conditions are created. But at queryAsyncJob of createAutoScaleVmProfile, it stops responding. Conditions and profile gets created in the DB: 

 10 | 192dbc28-b6e3-4df0-ab73-c4e7c359adfc | 1 | 70 | GT | 1 | 2 | NULL | 2012-07-31 07:13:25 | 
| 11 | 48f10dc4-0f4b-459b-91a7-2feb2109c322 | 1 | 30 | GT | 1 | 2 | NULL | 2012-07-31 07:13:32 | 


| 5 | c03f373c-1f7c-421a-8377-4c373a57cf71 | 1 | 1 | 2 | 2 | 1 | 5 | NULL | 30 | public | 161 | 2012-07-31 07:13:38 | NULL | 


Diffs
-----

  ui/scripts/autoscaler.js ff5c542 

Diff: https://reviews.apache.org/r/6245/diff/


Testing
-------

Verified on my local Cloudstack setup.


Thanks,

Sanjay Tripathi


Re: Review Request: CS-15775: Creation of Auto scale configuration through UI fails while creating autoscale profile due to args.context.ipAddresses is undefined

Posted by Deepak Garg <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6245/#review9677
-----------------------------------------------------------


It looks fine to me as well.


Thanks,
Deepak


- Deepak Garg


On Aug. 1, 2012, 4:21 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6245/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:21 a.m.)
> 
> 
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
> 
> 
> Description
> -------
> 
> Basic zone, EIP ELB N/w Offering. 
> Unable to create Autoscale policy from UI 
> Steps 
> ===== 
> 
> Network -> GuestNetwork -> AddLoadBalancer -> provide name/port -> Autoscale - Configure -> Provide all autoscale configs 
> 
> autoscale conditions are created. But at queryAsyncJob of createAutoScaleVmProfile, it stops responding. Conditions and profile gets created in the DB: 
> 
>  10 | 192dbc28-b6e3-4df0-ab73-c4e7c359adfc | 1 | 70 | GT | 1 | 2 | NULL | 2012-07-31 07:13:25 | 
> | 11 | 48f10dc4-0f4b-459b-91a7-2feb2109c322 | 1 | 30 | GT | 1 | 2 | NULL | 2012-07-31 07:13:32 | 
> 
> 
> | 5 | c03f373c-1f7c-421a-8377-4c373a57cf71 | 1 | 1 | 2 | 2 | 1 | 5 | NULL | 30 | public | 161 | 2012-07-31 07:13:38 | NULL | 
> 
> 
> This addresses bug CS-15775.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/autoscaler.js ff5c542 
> 
> Diff: https://reviews.apache.org/r/6245/diff/
> 
> 
> Testing
> -------
> 
> Verified on my local Cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CS-15775: Creation of Auto scale configuration through UI fails while creating autoscale profile due to args.context.ipAddresses is undefined

Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6245/#review9676
-----------------------------------------------------------

Ship it!


Verified the changes on my set up. Looks good !
Thanks for the patch .

- Pranav Saxena


On Aug. 1, 2012, 4:21 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6245/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 4:21 a.m.)
> 
> 
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
> 
> 
> Description
> -------
> 
> Basic zone, EIP ELB N/w Offering. 
> Unable to create Autoscale policy from UI 
> Steps 
> ===== 
> 
> Network -> GuestNetwork -> AddLoadBalancer -> provide name/port -> Autoscale - Configure -> Provide all autoscale configs 
> 
> autoscale conditions are created. But at queryAsyncJob of createAutoScaleVmProfile, it stops responding. Conditions and profile gets created in the DB: 
> 
>  10 | 192dbc28-b6e3-4df0-ab73-c4e7c359adfc | 1 | 70 | GT | 1 | 2 | NULL | 2012-07-31 07:13:25 | 
> | 11 | 48f10dc4-0f4b-459b-91a7-2feb2109c322 | 1 | 30 | GT | 1 | 2 | NULL | 2012-07-31 07:13:32 | 
> 
> 
> | 5 | c03f373c-1f7c-421a-8377-4c373a57cf71 | 1 | 1 | 2 | 2 | 1 | 5 | NULL | 30 | public | 161 | 2012-07-31 07:13:38 | NULL | 
> 
> 
> This addresses bug CS-15775.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/autoscaler.js ff5c542 
> 
> Diff: https://reviews.apache.org/r/6245/diff/
> 
> 
> Testing
> -------
> 
> Verified on my local Cloudstack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CS-15775: Creation of Auto scale configuration through UI fails while creating autoscale profile due to args.context.ipAddresses is undefined

Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6245/
-----------------------------------------------------------

(Updated Aug. 1, 2012, 4:21 a.m.)


Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.


Summary (updated)
-----------------

CS-15775: Creation of Auto scale configuration through UI fails while creating autoscale profile due to args.context.ipAddresses is undefined


Description
-------

Basic zone, EIP ELB N/w Offering. 
Unable to create Autoscale policy from UI 
Steps 
===== 

Network -> GuestNetwork -> AddLoadBalancer -> provide name/port -> Autoscale - Configure -> Provide all autoscale configs 

autoscale conditions are created. But at queryAsyncJob of createAutoScaleVmProfile, it stops responding. Conditions and profile gets created in the DB: 

 10 | 192dbc28-b6e3-4df0-ab73-c4e7c359adfc | 1 | 70 | GT | 1 | 2 | NULL | 2012-07-31 07:13:25 | 
| 11 | 48f10dc4-0f4b-459b-91a7-2feb2109c322 | 1 | 30 | GT | 1 | 2 | NULL | 2012-07-31 07:13:32 | 


| 5 | c03f373c-1f7c-421a-8377-4c373a57cf71 | 1 | 1 | 2 | 2 | 1 | 5 | NULL | 30 | public | 161 | 2012-07-31 07:13:38 | NULL | 


This addresses bug CS-15775.


Diffs
-----

  ui/scripts/autoscaler.js ff5c542 

Diff: https://reviews.apache.org/r/6245/diff/


Testing
-------

Verified on my local Cloudstack setup.


Thanks,

Sanjay Tripathi