You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/01/04 04:53:21 UTC

Re: [PR] [SPARK-46412][K8S][DOCS] Update Java and JDK info in K8S testing [spark]

dongjoon-hyun commented on code in PR #44589:
URL: https://github.com/apache/spark/pull/44589#discussion_r1441293010


##########
resource-managers/kubernetes/integration-tests/README.md:
##########
@@ -13,7 +13,7 @@ directory:
 
     ./dev/dev-run-integration-tests.sh
 
-To run tests with Java 11 instead of Java 8, use `--java-image-tag` to specify the base image.
+To run tests with Java 21 instead of Java 17, use `--java-image-tag` to specify the base image.

Review Comment:
   Thank you. However, new sentence is also wrong because we are running with Java 21 already. K8s-base Docker image is Java 21.
   
   https://github.com/apache/spark/blob/733be49a8078b70d44b26c392a15218c73f290e7/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org