[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #1017: [#973][Improvement] Make shuffle manager client RPC timeout configurable

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #1017:
URL: https://github.com/apache/incubator-uniffle/pull/1017#discussion_r1265588518


##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -129,6 +129,12 @@ public class RssBaseConf extends RssConf {
           .defaultValue(ClientType.GRPC)
           .withDescription("client type for rss");
 
+  public static final ConfigOption<Long> RSS_CLIENT_TYPE_GRPC_TIMEOUT =
+      ConfigOptions.key("rss.rpc.client.type.grpc.timeout")
+          .longType()

Review Comment:
   Could we use the method checkValue to validate the config option?



##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -129,6 +129,12 @@ public class RssBaseConf extends RssConf {
           .defaultValue(ClientType.GRPC)
           .withDescription("client type for rss");
 
+  public static final ConfigOption<Long> RSS_CLIENT_TYPE_GRPC_TIMEOUT =

Review Comment:
   `RSS_CLIENT_TYPE_GRPC_TIMEOUT_MS` may be a better name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org