[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4376: Config for overriding initial rows threshold in segment size auto tuning

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4376: Config for overriding initial rows threshold in segment size auto tuning
URL: https://github.com/apache/incubator-pinot/pull/4376#discussion_r298404576
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/StreamConfigProperties.java
 ##########
 @@ -89,6 +89,11 @@
    */
   public static final String SEGMENT_FLUSH_DESIRED_SIZE = "realtime.segment.flush.desired.size";
 
+  /**
+   * The initial num rows to use for segment size auto tuning. By default 100_000 is used.
+   */
+  public static final String SEGMENT_INITIAL_ROWS_THRESHOLD = "realtime.segment.initial.rows.threshold";
 
 Review comment:
   I suggest "realtime.segment.flush.initial.rows.threshold". What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org