You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/03/08 02:03:47 UTC
Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/
-----------------------------------------------------------
Review request for Aurora and Stephan Erb.
Repository: aurora
Description
-------
The `acceptOffers` log message outputs the entire `Operation` object which for
the `LAUNCH` type includes the entire `TaskInfo`. This makes the log output
massive. This reduces the logging to just the type of the operation.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
Diff: https://reviews.apache.org/r/57404/diff/1/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168331
-----------------------------------------------------------
@ReviewBot retry
- Zameer Manji
On March 7, 2017, 6:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57404/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 6:05 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `acceptOffers` log message outputs the entire `Operation` object which for
> the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
> massive. This reduces the logging to just the type of the operation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
>
>
> Diff: https://reviews.apache.org/r/57404/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168323
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On March 8, 2017, 2:05 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57404/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 2:05 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `acceptOffers` log message outputs the entire `Operation` object which for
> the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
> massive. This reduces the logging to just the type of the operation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
>
>
> Diff: https://reviews.apache.org/r/57404/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168332
-----------------------------------------------------------
Master (932e908) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 8, 2017, 2:05 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57404/
> -----------------------------------------------------------
>
> (Updated March 8, 2017, 2:05 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `acceptOffers` log message outputs the entire `Operation` object which for
> the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
> massive. This reduces the logging to just the type of the operation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
>
>
> Diff: https://reviews.apache.org/r/57404/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168235
-----------------------------------------------------------
Master (932e908) is red with this patch.
./build-support/jenkins/build.sh
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/storage/db/views/DbImage
Test coverage missing for org/apache/aurora/scheduler/http/Mname
Test coverage missing for org/apache/aurora/scheduler/http/Services
Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
Test coverage missing for org/apache/aurora/scheduler/http/Cron
Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 14 mins 42.904 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 7, 2017, 6:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57404/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 6:05 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `acceptOffers` log message outputs the entire `Operation` object which for
> the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
> massive. This reduces the logging to just the type of the operation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
>
>
> Diff: https://reviews.apache.org/r/57404/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/#review168329
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On M�rz 8, 2017, 3:05 vorm., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57404/
> -----------------------------------------------------------
>
> (Updated M�rz 8, 2017, 3:05 vorm.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The `acceptOffers` log message outputs the entire `Operation` object which for
> the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
> massive. This reduces the logging to just the type of the operation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
>
>
> Diff: https://reviews.apache.org/r/57404/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/
-----------------------------------------------------------
(Updated March 7, 2017, 6:05 p.m.)
Review request for Aurora and Stephan Erb.
Changes
-------
Remove unused imports.
Repository: aurora
Description
-------
The `acceptOffers` log message outputs the entire `Operation` object which for
the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
massive. This reduces the logging to just the type of the operation.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
Diff: https://reviews.apache.org/r/57404/diff/2/
Changes: https://reviews.apache.org/r/57404/diff/1-2/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 57404: Reduce log output in
`VersionedSchedulerDriverService`.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57404/
-----------------------------------------------------------
(Updated March 7, 2017, 6:04 p.m.)
Review request for Aurora and Stephan Erb.
Repository: aurora
Description (updated)
-------
The `acceptOffers` log message outputs the entire `Operation` object which for
the `LAUNCH` type includes the entire `TaskInfo` protobuf. This makes the log output
massive. This reduces the logging to just the type of the operation.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4
Diff: https://reviews.apache.org/r/57404/diff/1/
Testing
-------
Thanks,
Zameer Manji