[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6364: Cleanup ExternalSorter metrics (#5885)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6364:
URL: https://github.com/apache/arrow-datafusion/pull/6364#discussion_r1195630138


##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -56,6 +55,27 @@ use tempfile::NamedTempFile;
 use tokio::sync::mpsc::{Receiver, Sender};
 use tokio::task;
 
+struct ExternalSorterMetrics {

Review Comment:
   I agree it is much nicer to put sorting metrics on the sorter rather than BaselineMetrics



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org