You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/12 06:56:35 UTC

[GitHub] [kafka] zhpyc opened a new pull request, #13105: MINOR: fix typo in KafkaConsumer.java #99999

zhpyc opened a new pull request, #13105:
URL: https://github.com/apache/kafka/pull/13105

   ### Change Logs
   As above.
   
   ### Impact
   Only typo fixes.
   
   ### Risk level (write none, low medium or high below)
   None
   
   ### Documentation Update
   N/A
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] github-actions[bot] commented on pull request #13105: MINOR: fix typo in KafkaConsumer.java

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13105:
URL: https://github.com/apache/kafka/pull/13105#issuecomment-1585816401

   This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has  merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on a diff in pull request #13105: MINOR: fix typo in KafkaConsumer.java

Posted by GitBox <gi...@apache.org>.
dengziming commented on code in PR #13105:
URL: https://github.com/apache/kafka/pull/13105#discussion_r1067804443


##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -2460,7 +2460,7 @@ private void close(long timeoutMs, boolean swallowException) {
      * @throws org.apache.kafka.common.errors.AuthenticationException if authentication fails. See the exception for more details
      * @throws NoOffsetForPartitionException If no offset is stored for a given partition and no offset reset policy is
      *             defined
-     * @return true iff the operation completed without timing out

Review Comment:
   This change is unnecessary, here, iif means if and only if.



##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -2460,7 +2460,7 @@ private void close(long timeoutMs, boolean swallowException) {
      * @throws org.apache.kafka.common.errors.AuthenticationException if authentication fails. See the exception for more details
      * @throws NoOffsetForPartitionException If no offset is stored for a given partition and no offset reset policy is
      *             defined
-     * @return true iff the operation completed without timing out

Review Comment:
   This change is unnecessary, here, iff means if and only if.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a diff in pull request #13105: MINOR: fix typo in KafkaConsumer.java

Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #13105:
URL: https://github.com/apache/kafka/pull/13105#discussion_r1070519853


##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -1472,7 +1472,7 @@ public boolean isDone() {
     /**
      * Callbacks that are called by the RecordAccumulator append functions:
      *  - user callback
-     *  - interceptor callbacks
+     *  - interceptor callback

Review Comment:
   There can be multiple interceptors and that's likely the reason why it says `callbacks` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] zhpyc closed pull request #13105: MINOR: fix typo in KafkaConsumer.java

Posted by "zhpyc (via GitHub)" <gi...@apache.org>.
zhpyc closed pull request #13105: MINOR: fix typo in KafkaConsumer.java
URL: https://github.com/apache/kafka/pull/13105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org