You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/18 01:24:43 UTC

[GitHub] [incubator-nuttx] justinmclean commented on a change in pull request #581: SocketCAN initial beta

justinmclean commented on a change in pull request #581: SocketCAN initial beta
URL: https://github.com/apache/incubator-nuttx/pull/581#discussion_r394057870
 
 

 ##########
 File path: include/nuttx/can/error.h
 ##########
 @@ -0,0 +1,127 @@
+/* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */
 
 Review comment:
   It's BSD licensed so that fine. The BSD license need to be added to our LICENSE file (if it hasn't been). Unless major changes have been made I would leave the original BSD headers on the code and not put an ASF header on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services