You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/12 23:53:03 UTC

[GitHub] [beam] robertwb commented on issue #11067: [BEAM-9136]Add licenses for dependencies

robertwb commented on issue #11067: [BEAM-9136]Add licenses for dependencies
URL: https://github.com/apache/beam/pull/11067#issuecomment-598481904
 
 
   I'll second the comment that we should include the list of license files in the beam repository itself, but just add the script to the container build process to install them into the container. 
   
   In terms of checking, this script would fail if it was not able to figure out the license for a dependency. This way whoever adds the new dependency would be responsible for making sure we were able to get its license in order to get the PR green. (We should be building containers as part of our precommits.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services