You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/16 13:14:59 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8047:
[database] Improve connection URI validation
codecov-io edited a comment on issue #8047: [database] Improve connection URI validation
URL: https://github.com/apache/incubator-superset/pull/8047#issuecomment-522004681
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=h1) Report
> Merging [#8047](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/613dcf5def6b6c7e3eedbaac442614edd38a95b8?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `82.14%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8047/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8047 +/- ##
==========================================
+ Coverage 65.56% 65.58% +0.01%
==========================================
Files 469 469
Lines 22478 22510 +32
Branches 2442 2444 +2
==========================================
+ Hits 14738 14763 +25
- Misses 7620 7627 +7
Partials 120 120
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `83.69% <100%> (+1.13%)` | :arrow_up: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `79.1% <73.68%> (-2.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.98% <0%> (-0.09%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.58% <0%> (-0.03%)` | :arrow_down: |
| [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `8.06% <0%> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.7% <0%> (ø)` | :arrow_up: |
| [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `11.11% <0%> (ø)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8047/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `80.13% <0%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=footer). Last update [613dcf5...c315b60](https://codecov.io/gh/apache/incubator-superset/pull/8047?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org