You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <jo...@gmail.com> on 2016/01/04 23:08:17 UTC
Review Request 41895: Fix Kerberos5ShiroRealmModule: use dedicated
jaas config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41895/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
This fix to Kerberos initialization that moves away from setting a
system property to instead use a ConfigFile object directly.
This prevents using the default LoginContext internals and entering
into races with other components (notably zookeeper).
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9
Diff: https://reviews.apache.org/r/41895/diff/
Testing
-------
I now have `./build-support/jenkins/build.sh` and
`./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green
locally.
Prior to this last fix (see depends-on chain for 2 others), got:
```
org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED
java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start.
at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53)
at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96)
at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
...
```
Thanks,
John Sirois
Re: Review Request 41895: Fix Kerberos5ShiroRealmModule: use
dedicated jaas config.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 4, 2016, 4:14 p.m., Bill Farner wrote:
> > Ship It!
Preempting Zameer's review since we also had Maxim chime in.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41895/#review112699
-----------------------------------------------------------
On Jan. 4, 2016, 2:08 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41895/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 2:08 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This fix to Kerberos initialization that moves away from setting a
> system property to instead use a ConfigFile object directly.
> This prevents using the default LoginContext internals and entering
> into races with other components (notably zookeeper).
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9
>
> Diff: https://reviews.apache.org/r/41895/diff/
>
>
> Testing
> -------
>
> I now have `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green
> locally.
>
> Prior to this last fix (see depends-on chain for 2 others), got:
> ```
> org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED
>
> java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start.
> at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53)
> at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96)
> at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
> at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
> ...
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41895: Fix Kerberos5ShiroRealmModule: use
dedicated jaas config.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41895/#review112699
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 4, 2016, 2:08 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41895/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 2:08 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This fix to Kerberos initialization that moves away from setting a
> system property to instead use a ConfigFile object directly.
> This prevents using the default LoginContext internals and entering
> into races with other components (notably zookeeper).
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9
>
> Diff: https://reviews.apache.org/r/41895/diff/
>
>
> Testing
> -------
>
> I now have `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green
> locally.
>
> Prior to this last fix (see depends-on chain for 2 others), got:
> ```
> org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED
>
> java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start.
> at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53)
> at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96)
> at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
> at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
> ...
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41895: Fix Kerberos5ShiroRealmModule: use
dedicated jaas config.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41895/#review112663
-----------------------------------------------------------
Master (8706a78) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 4, 2016, 10:08 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41895/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 10:08 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This fix to Kerberos initialization that moves away from setting a
> system property to instead use a ConfigFile object directly.
> This prevents using the default LoginContext internals and entering
> into races with other components (notably zookeeper).
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9
>
> Diff: https://reviews.apache.org/r/41895/diff/
>
>
> Testing
> -------
>
> I now have `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green
> locally.
>
> Prior to this last fix (see depends-on chain for 2 others), got:
> ```
> org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED
>
> java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start.
> at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53)
> at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96)
> at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
> at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
> ...
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 41895: Fix Kerberos5ShiroRealmModule: use
dedicated jaas config.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41895/#review112674
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 4, 2016, 10:08 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41895/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 10:08 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This fix to Kerberos initialization that moves away from setting a
> system property to instead use a ConfigFile object directly.
> This prevents using the default LoginContext internals and entering
> into races with other components (notably zookeeper).
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java 09d8db4cdaa6e9320bc2e8bb455adf16c4ec64f9
>
> Diff: https://reviews.apache.org/r/41895/diff/
>
>
> Testing
> -------
>
> I now have `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` green
> locally.
>
> Prior to this last fix (see depends-on chain for 2 others), got:
> ```
> org.apache.aurora.scheduler.app.SchedulerIT > testLaunch FAILED
>
> java.io.IOException: Could not find a 'Server' entry in this configuration: Server cannot start.
> at org.apache.zookeeper.server.auth.SaslServerCallbackHandler.<init>(SaslServerCallbackHandler.java:53)
> at org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:96)
> at org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:81)
> at org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.setUp(BaseZooKeeperTest.java:64)
> ...
> ```
>
>
> Thanks,
>
> John Sirois
>
>