[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1432: chore: added global files to contain test selector mappers and public data

[GitBox <gi...@apache.org>]

LiteSun commented on a change in pull request #1432:
URL: https://github.com/apache/apisix-dashboard/pull/1432#discussion_r570667732



##########
File path: web/cypress/integration/metrics/metrics-smoketest.spec.js
##########
@@ -17,20 +17,17 @@
 /* eslint-disable no-undef */
 
 context('metrics page smoke test', () => {
-  const domSelectors = {
-    pageContent: '.ant-pro-page-container',
-  };
-
   beforeEach(() => {
     cy.login();
+
+    cy.fixture('selector.json').as('domSelector');
   });
 
-  it('visit metrics page', () => {
-    // go to metrics page
+  it('visit metrics page', function () {

Review comment:
       ```suggestion
     it('should visit metrics page', function () {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org