You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/10/27 12:52:14 UTC
[GitHub] [dolphinscheduler] zhongjiajie opened a new issue #6619: [Feature][unittest] Recover UT in
zhongjiajie opened a new issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In we merge PR https://github.com/apache/dolphinscheduler/pull/6182 by accident, in https://github.com/apache/dolphinscheduler/pull/6182#issuecomment-918220975 we know that we should make this unittest work instead of remove it, this issue aim to make unittest work again https://github.com/apache/dolphinscheduler/pull/6182/files#diff-b00a40cfdd8da6a4979ff539b3f64954989b5abeb5ba9e74829ec31bcbe22160L58-L64
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Linkaiup commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
Linkaiup commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958690536
@zhongjiajie I had submit a PR,looking forward to your merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-960419117
> @zhongjiajie I had submit a PR,looking forward to your merge.
@Linkaiup So sorry that I have not permission to merge PR, but I mention someone who have to start CI and review the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Linkaiup commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
Linkaiup commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958646185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Linkaiup commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
Linkaiup commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958646185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Linkaiup commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
Linkaiup commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958646185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-952897635
Please add label `good first issue` to this issue, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #6619: [Feature][unittest] Recover UT in
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-952895334
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958674490
Hi @Linkaiup Thanks for your feedback, and yeah for sure you could task it! looking forward your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958674490
Hi @Linkaiup Thanks for your feedback, and yeah for sure you could task it! looking forward your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958674490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Linkaiup commented on issue #6619: [Feature][unittest] Recover UT in AlertPluginManagerTest.java
Posted by GitBox <gi...@apache.org>.
Linkaiup commented on issue #6619:
URL: https://github.com/apache/dolphinscheduler/issues/6619#issuecomment-958646185
I want to take this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org