[GitHub] [ozone] Xushaohong commented on a diff in pull request #4128: HDDS-5686. Support transfer leadership

["Xushaohong (via GitHub)" <gi...@apache.org>]

Xushaohong commented on code in PR #4128:
URL: https://github.com/apache/ozone/pull/4128#discussion_r1098555867


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java:
##########
@@ -488,4 +490,64 @@ public static void debug(ByteBuf buf, String name, Logger log) {
     }
     log.debug("{}: {}\n  {}", name, buf, builder);
   }
+
+
+  /**
+   * Use raft client to send admin request, transfer the leadership.
+   * 1. Set priority and send setConfiguration request

Review Comment:
   Hi @kaijchen. This whole process is done on the server side by ozone. Once a new version of API is coming, we can simply delete the Setting priority part and do not need to worry about the ozone client's compatibility, since the ozone client has its own PB sending the "target NodeId". 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org