You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/05/05 09:12:53 UTC
Review Request 58997: Users are not able to login to ambari UI after
Ambari upgrade from 2.4.x to 2.5.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako.
Bugs: AMBARI-20936
https://issues.apache.org/jira/browse/AMBARI-20936
Repository: ambari
Description
-------
Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8
ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3
Diff: https://reviews.apache.org/r/58997/diff/1/
Testing
-------
added : ViewInstanceOperationHandlerTest.java
updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance.
Thanks,
Nitiraj Rathore
Re: Review Request 58997: Users are not able to login to ambari UI
after Ambari upgrade from 2.4.x to 2.5.0
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174152
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 9:12 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako.
>
>
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3
>
>
> Diff: https://reviews.apache.org/r/58997/diff/1/
>
>
> Testing
> -------
>
> added : ViewInstanceOperationHandlerTest.java
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
>
> Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 58997: Users are not able to login to ambari UI
after Ambari upgrade from 2.4.x to 2.5.0
Posted by Ashwin Rajeev <ar...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174148
-----------------------------------------------------------
Ship it!
Ship It!
- Ashwin Rajeev
On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 9:12 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako.
>
>
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3
>
>
> Diff: https://reviews.apache.org/r/58997/diff/1/
>
>
> Testing
> -------
>
> added : ViewInstanceOperationHandlerTest.java
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
>
> Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 58997: Users are not able to login to ambari UI
after Ambari upgrade from 2.4.x to 2.5.0
Posted by Nitiraj Rathore <ni...@gmail.com>.
> On May 8, 2017, 9:32 a.m., Ashwin Rajeev wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
> > Lines 692 (patched)
> > <https://reviews.apache.org/r/58997/diff/1/?file=1709264#file1709264line692>
> >
> > Does it need to be hardcoded ?
It's fine as it is specifically for that view only.
- Nitiraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174147
-----------------------------------------------------------
On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 9:12 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako.
>
>
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3
>
>
> Diff: https://reviews.apache.org/r/58997/diff/1/
>
>
> Testing
> -------
>
> added : ViewInstanceOperationHandlerTest.java
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
>
> Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 58997: Users are not able to login to ambari UI
after Ambari upgrade from 2.4.x to 2.5.0
Posted by Ashwin Rajeev <ar...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174147
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
Lines 692 (patched)
<https://reviews.apache.org/r/58997/#comment247267>
Does it need to be hardcoded ?
- Ashwin Rajeev
On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58997/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 9:12 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, Ashwin Rajeev, and Yusaku Sako.
>
>
> Bugs: AMBARI-20936
> https://issues.apache.org/jira/browse/AMBARI-20936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Instead of deleting entries from DB directly, used uninstalling. Did refactoring to take the DB related code out of the ViewRegistry (which is anyway growing very big and is live object which cannot be used during Upgrade process) to create ViewInstanceOperationHandler.java.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java ba39efb6a2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 74de530ad7
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java b632c54043
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java d076a5c3b1
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java d136db7e49
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java 190779add8
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a3728d46b3
>
>
> Diff: https://reviews.apache.org/r/58997/diff/1/
>
>
> Testing
> -------
>
> added : ViewInstanceOperationHandlerTest.java
> updated : UpgradeCatalog250Test.java, ViewRegistryTest.java
>
> Manual testing to see if upgrade works fine with and without LDAP users and privileges along with UI deletion of view instance.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>