You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2012/12/01 10:31:59 UTC
[jira] [Created] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Jukka Zitting created JCR-3474:
----------------------------------
Summary: Add JackrabbitQueryResult.getTotalSize()
Key: JCR-3474
URL: https://issues.apache.org/jira/browse/JCR-3474
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-api, jackrabbit-core
Reporter: Jukka Zitting
Assignee: Jukka Zitting
Priority: Minor
In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508598#comment-13508598 ]
Alex Parvulescu edited comment on JCR-3474 at 12/3/12 9:21 AM:
---------------------------------------------------------------
With this fix you also removed the possibility to run this test from outside jackrabbit :( , See OAK-237 [0].
We had this test included in Oak as well [1], and isJackrabbitImpl the flag allowed us to prevent a class cast exception [2].
[0] https://issues.apache.org/jira/browse/OAK-237
[1] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/query/QueryJcrTest.java?view=markup#l52
[2] https://issues.apache.org/jira/browse/JCR-3429
was (Author: alex.parvulescu):
With this fix you also removed the possibility to run this test from outside jackrabbit :(
We had this test included in Oak as well, and {{isJackrabbitImpl}} the flag allowed us to prevent a class cast exception.
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.5.3
>
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-3474.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.5.3
Done in revision 1415968.
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.5.3
>
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508601#comment-13508601 ]
Jukka Zitting commented on JCR-3474:
------------------------------------
I replaced the isJackrabbitImpl flag with an instanceof check on JackrabbitQueryResult. That should prevent the possible cast exception, or did I miss something?
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.5.3
>
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-3474:
-------------------------------
Issue Type: Improvement (was: Bug)
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508606#comment-13508606 ]
Alex Parvulescu commented on JCR-3474:
--------------------------------------
ah, right :) I stand corrected, you covered everything. sorry for the noise.
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.5.3
>
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3474) Add
JackrabbitQueryResult.getTotalSize()
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508598#comment-13508598 ]
Alex Parvulescu commented on JCR-3474:
--------------------------------------
With this fix you also removed the possibility to run this test from outside jackrabbit :(
We had this test included in Oak as well, and {{isJackrabbitImpl}} the flag allowed us to prevent a class cast exception.
> Add JackrabbitQueryResult.getTotalSize()
> ----------------------------------------
>
> Key: JCR-3474
> URL: https://issues.apache.org/jira/browse/JCR-3474
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-api, jackrabbit-core
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 2.5.3
>
>
> In JCR-1073 we added the QueryResultImpl.getTotalSize() method for getting the total number of matching results, regardless of possible limit or offset settings. It would be nice if this method was available through a JackrabbitQueryResult extension interface instead of just by casting a QueryResult instance to the QueryResultImpl implementation class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira