You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2013/08/30 07:14:52 UTC

[jira] [Commented] (HBASE-9382) replicateWALEntry doesn't use the replication handlers

    [ https://issues.apache.org/jira/browse/HBASE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754379#comment-13754379 ] 

stack commented on HBASE-9382:
------------------------------

Broken by:

{code}
------------------------------------------------------------------------
r1501834 | stack | 2013-07-10 09:30:32 -0700 (Wed, 10 Jul 2013) | 1 line

HBASE-8915 protobuf message style
{code}

The priority checker thingy is brittle. It looks at name of incoming method to figure priority (we should do Elliott idea of having client just say what priority they want).  The above change did this kinda thing:

{code}
  3 -  rpc replicateWALEntry(ReplicateWALEntryRequest)
  2 +  rpc ReplicateWALEntry(ReplicateWALEntryRequest)
  1      returns(ReplicateWALEntryResponse);
{code}

When we ask the regionserver its method via reflection it returns the proper java method name 'replicationWALEntry' but incoming, pb has method name as 'ReplicationWALEntry'.
                
> replicateWALEntry doesn't use the replication handlers
> ------------------------------------------------------
>
>                 Key: HBASE-9382
>                 URL: https://issues.apache.org/jira/browse/HBASE-9382
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: stack
>             Fix For: 0.98.0, 0.96.0
>
>
> By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira