You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tommaso Teofili (JIRA)" <ji...@apache.org> on 2015/06/22 16:09:00 UTC
[jira] [Updated] (SLING-4828) JobManagerImpl job persisting doesn't
check the created resource
[ https://issues.apache.org/jira/browse/SLING-4828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommaso Teofili updated SLING-4828:
-----------------------------------
Description:
{{JobManagerImpl#addJob}} persists the job to be started in {{writeJob}} however the result of {{ResourceHelper.getOrCreateResource}} is neither checked (!=null) nor used so it can be that the returned {{Resource}} is null or corrupted and therefore the job could not be persisted correctly, see https://github.com/apache/sling/blob/trunk/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L846.
E.g. I've experienced some cases where a binary property of a JCR node ends up being null but that is only noticed when the job is executed, not when it's persisted.
was:
{{JobManagerImpl#addJob}} persists the job to be started in {{writeJob}} however the result of {{ResourceHelper.getOrCreateResource}} is neither checked (!=null) nor used so it can be that the returned {{Resource}} is null or corrupted and therefore the job could not be persisted correctly.
E.g. I've experienced some cases where a binary property of a JCR node ends up being null but that is only noticed when the job is executed, not when it's persisted.
> JobManagerImpl job persisting doesn't check the created resource
> -----------------------------------------------------------------
>
> Key: SLING-4828
> URL: https://issues.apache.org/jira/browse/SLING-4828
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: Event 3.6.0
> Reporter: Tommaso Teofili
>
> {{JobManagerImpl#addJob}} persists the job to be started in {{writeJob}} however the result of {{ResourceHelper.getOrCreateResource}} is neither checked (!=null) nor used so it can be that the returned {{Resource}} is null or corrupted and therefore the job could not be persisted correctly, see https://github.com/apache/sling/blob/trunk/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L846.
> E.g. I've experienced some cases where a binary property of a JCR node ends up being null but that is only noticed when the job is executed, not when it's persisted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)