You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/27 13:04:54 UTC
[GitHub] [flink] matriv opened a new pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
matriv opened a new pull request #17579:
URL: https://github.com/apache/flink/pull/17579
Check for `CAST` tests in other classes, move them in `CastFunctionITCase`,
or completely remove them if are already contained in `CastFunctionITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r740022369
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -88,9 +130,10 @@ protected Configuration configuration() {
// https://issues.apache.org/jira/browse/FLINK-24413 - Trim to precision
// in this case down to 3 chars
.fromCase(STRING(), "abcdef", "abcdef") // "abc"
- .fromCase(DATE(), LocalDate.parse("2021-09-30"), "2021-09-30") // "202"
+ .fromCase(DATE(), DEFAULT_DATE, "2021-09-24") // "202"
Review comment:
"trim to 3 chars" due to the `CHAR(3)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17579:
URL: https://github.com/apache/flink/pull/17579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r738279632
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -191,149 +210,159 @@ protected Configuration configuration() {
.failTableApi(FLOAT(), -123.456)
.failTableApi(DOUBLE(), 0)
// Not supported - no fix
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(), LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(), fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
// MULTISET
// MAP
// ROW
// RAW
.build(),
CastTestSpecBuilder.testCastTo(BINARY(2))
+ .fromCase(BINARY(5), null, null)
.fromCase(CHAR(3), "foo", new byte[] {102, 111, 111})
.fromCase(VARCHAR(5), "Flink", new byte[] {70, 108, 105, 110, 107})
// https://issues.apache.org/jira/browse/FLINK-24419 - not trimmed to 2
// bytes
.fromCase(STRING(), "Apache", new byte[] {65, 112, 97, 99, 104, 101})
// Not supported - no fix
- // BOOLEAN
+ .fail(BOOLEAN(), randomBoolean())
+ //
.fromCase(BINARY(2), new byte[] {0, 1}, new byte[] {0, 1})
.fromCase(VARBINARY(3), new byte[] {0, 1, 2}, new byte[] {0, 1, 2})
.fromCase(BYTES(), new byte[] {0, 1, 2, 3, 4}, new byte[] {0, 1, 2, 3, 4})
// Not supported - no fix
- // DECIMAL
- // TINYINT
- // SMALLINT
- // INT
- // BIGINT
- // FLOAT
- // DOUBLE
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DECIMAL(5, 3), 12.345)
+ .fail(TINYINT(), (byte) 5)
+ .fail(SMALLINT(), (short) 12)
+ .fail(INT(), 122345)
+ .fail(BIGINT(), 12345678912L)
+ .fail(FLOAT(), 1.2345)
+ .fail(DOUBLE(), 1.23456789)
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(), LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(), fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
Review comment:
Nice idea, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
* a0fccf63b7eab38abde54aa477e7ad3bc63d8569 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
}, {
"hash" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0fccf63b7eab38abde54aa477e7ad3bc63d8569 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689)
* 5f3ff3022cca123aa006768eaac44da735aecd1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r738258450
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -191,149 +210,159 @@ protected Configuration configuration() {
.failTableApi(FLOAT(), -123.456)
.failTableApi(DOUBLE(), 0)
// Not supported - no fix
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(), LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(), fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
// MULTISET
// MAP
// ROW
// RAW
.build(),
CastTestSpecBuilder.testCastTo(BINARY(2))
+ .fromCase(BINARY(5), null, null)
.fromCase(CHAR(3), "foo", new byte[] {102, 111, 111})
.fromCase(VARCHAR(5), "Flink", new byte[] {70, 108, 105, 110, 107})
// https://issues.apache.org/jira/browse/FLINK-24419 - not trimmed to 2
// bytes
.fromCase(STRING(), "Apache", new byte[] {65, 112, 97, 99, 104, 101})
// Not supported - no fix
- // BOOLEAN
+ .fail(BOOLEAN(), randomBoolean())
+ //
.fromCase(BINARY(2), new byte[] {0, 1}, new byte[] {0, 1})
.fromCase(VARBINARY(3), new byte[] {0, 1, 2}, new byte[] {0, 1, 2})
.fromCase(BYTES(), new byte[] {0, 1, 2, 3, 4}, new byte[] {0, 1, 2, 3, 4})
// Not supported - no fix
- // DECIMAL
- // TINYINT
- // SMALLINT
- // INT
- // BIGINT
- // FLOAT
- // DOUBLE
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DECIMAL(5, 3), 12.345)
+ .fail(TINYINT(), (byte) 5)
+ .fail(SMALLINT(), (short) 12)
+ .fail(INT(), 122345)
+ .fail(BIGINT(), 12345678912L)
+ .fail(FLOAT(), 1.2345)
+ .fail(DOUBLE(), 1.23456789)
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(), LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(), fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
Review comment:
btw have you thought about introducing a default value for every type in this test. I think reading `DEFAULT_INT` or `DEFAULT_ARRAY_INT` would improve the readability. One can still add non default values for specific tests that test e.g. boundaries.
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -930,16 +1066,44 @@ private TestSpec build() {
int idxOffset = 0;
for (int i = 0; i < columnData.size(); i++) {
String colName = "f" + i;
+ LogicalType colType = columnTypes.get(i).getLogicalType();
+ String errorMsg;
switch (testTypes.get(i)) {
case ERROR_TABLE_API:
- testSpec.testTableApiValidationError(
- $(colName).cast(targetType),
- String.format(
- "Invalid function call:%ncast("
- + columnTypes.get(i).toString()
- + ", "
- + targetType.toString()
- + ")"));
+ if (isTimestampLtzToNumeric(colType, targetType.getLogicalType())) {
Review comment:
maybe move those in a dedicated method for `specific errors` or `hint errors`?
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -144,14 +144,10 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
testSqlApi("CASE WHEN 'a'='a' THEN 1 END", "1")
testSqlApi("CASE 2 WHEN 1 THEN 'a' WHEN 2 THEN 'bcd' END", "bcd")
testSqlApi("CASE 1 WHEN 1 THEN 'a' WHEN 2 THEN 'bcd' END", "a")
- testSqlApi("CASE 1 WHEN 1 THEN CAST ('a' as varchar(1)) WHEN 2 THEN " +
Review comment:
I would still keep this. As we had issue with `org.apache.calcite.rel.type.RelDataTypeSystem#shouldConvertRaggedUnionTypesToVarying`
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -966,4 +1130,21 @@ private static Instant fromLocalToUTC(LocalDateTime localDateTime) {
private static Instant fromLocalTZ(String str) {
return LocalDateTime.parse(str).toInstant(TEST_OFFSET);
}
+
+ private static boolean randomBoolean() {
Review comment:
randomness in tests is never a good idea
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -184,17 +184,17 @@
castTo(DATE)
.implicitFrom(DATE, TIMESTAMP_WITHOUT_TIME_ZONE)
- .explicitFromFamily(TIMESTAMP, CHARACTER_STRING, BINARY_STRING)
Review comment:
can we put such change in `table-common` into separate commits. this change should be visible in the log afterwards.
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscFunctionsITCase.java
##########
@@ -46,7 +46,9 @@
"INT NOT NULL",
DataTypes.STRING())
.testTableApiValidationError(
- call("TYPEOF", $("f0"), $("f2")), "Invalid input arguments.")
+ call("TYPEOF", $("f0"), $("f2")),
Review comment:
hotfix commit? not really related to the JIRA issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17579:
URL: https://github.com/apache/flink/pull/17579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
* a0fccf63b7eab38abde54aa477e7ad3bc63d8569 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
}, {
"hash" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25706",
"triggerID" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f3ff3022cca123aa006768eaac44da735aecd1f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25706)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
}, {
"hash" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25706",
"triggerID" : "5f3ff3022cca123aa006768eaac44da735aecd1f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0fccf63b7eab38abde54aa477e7ad3bc63d8569 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689)
* 5f3ff3022cca123aa006768eaac44da735aecd1f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25706)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17579:
URL: https://github.com/apache/flink/pull/17579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r738279295
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -184,17 +184,17 @@
castTo(DATE)
.implicitFrom(DATE, TIMESTAMP_WITHOUT_TIME_ZONE)
- .explicitFromFamily(TIMESTAMP, CHARACTER_STRING, BINARY_STRING)
Review comment:
Of course, I had it in mind to do this split but forgot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r738280594
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -966,4 +1130,21 @@ private static Instant fromLocalToUTC(LocalDateTime localDateTime) {
private static Instant fromLocalTZ(String str) {
return LocalDateTime.parse(str).toInstant(TEST_OFFSET);
}
+
+ private static boolean randomBoolean() {
Review comment:
I thought it's a not so important thing, since we test the cast from `BOOLEAN` type overall, but if you feel uneasy, I can do with default value as well for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 882e66550fcf5429df68cb5a7321f3d1872d7898 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952910361
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 882e66550fcf5429df68cb5a7321f3d1872d7898 (Wed Oct 27 13:08:13 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-952911703
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"triggerType" : "PUSH"
}, {
"hash" : "882e66550fcf5429df68cb5a7321f3d1872d7898",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25522",
"triggerID" : "953300504",
"triggerType" : "MANUAL"
}, {
"hash" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689",
"triggerID" : "a0fccf63b7eab38abde54aa477e7ad3bc63d8569",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a0fccf63b7eab38abde54aa477e7ad3bc63d8569 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25689)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r740020822
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -979,6 +1265,30 @@ private TestSpec build() {
.testResult(testSpecs.toArray(new ResultSpec[0]));
return testSpec;
}
+
+ private String tableApiSpecificErrorMsg(int i, LogicalType colType, String defaultMsg) {
Review comment:
this looks like duplicate code to me that can be merged with the method below? also `i` is not used.
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -88,9 +130,10 @@ protected Configuration configuration() {
// https://issues.apache.org/jira/browse/FLINK-24413 - Trim to precision
// in this case down to 3 chars
.fromCase(STRING(), "abcdef", "abcdef") // "abc"
- .fromCase(DATE(), LocalDate.parse("2021-09-30"), "2021-09-30") // "202"
+ .fromCase(DATE(), DEFAULT_DATE, "2021-09-24") // "202"
Review comment:
What was the `202` referring to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r739027043
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -966,4 +1130,21 @@ private static Instant fromLocalToUTC(LocalDateTime localDateTime) {
private static Instant fromLocalTZ(String str) {
return LocalDateTime.parse(str).toInstant(TEST_OFFSET);
}
+
+ private static boolean randomBoolean() {
Review comment:
Yes, I think it is just not necessary. We should keep tests simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-953300504
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17579: [FLINK-24454][table-planner][tests] Consolidate cast tests
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17579:
URL: https://github.com/apache/flink/pull/17579#issuecomment-955784627
@twalthr Please check again, I created 2 extra hotfix commits, I'll squash the rest once it's approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org