You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/11/30 17:02:43 UTC

[GitHub] [zeppelin] pan3793 opened a new pull request, #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

pan3793 opened a new pull request, #4522:
URL: https://github.com/apache/zeppelin/pull/4522

   ### What is this PR for?
   
   Bump bouncycastle 1.70.
   
   ```
   ➜  apache-zeppelin git:(master) java -version
   openjdk version "1.8.0_332"
   OpenJDK Runtime Environment (Zulu 8.62.0.19-CA-macos-aarch64) (build 1.8.0_332-b09)
   OpenJDK 64-Bit Server VM (Zulu 8.62.0.19-CA-macos-aarch64) (build 25.332-b09, mixed mode)
   ```
   
   The transitive dependencies can not be resolved correctly on my mac when using bouncycastle 1.60, and the build failed w/ same reason.
   
   <img width="376" alt="image" src="https://user-images.githubusercontent.com/26535726/204861095-fd660d7c-a39a-4902-9528-07ac26ccaf37.png">
   
   ```
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project zeppelin-zengine: Compilation failure: Compilation failure:
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[20,31] package org.bouncycastle.crypto does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[21,31] package org.bouncycastle.crypto does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[22,39] package org.bouncycastle.crypto.engines does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[23,40] package org.bouncycastle.crypto.paddings does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[24,40] package org.bouncycastle.crypto.paddings does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[25,38] package org.bouncycastle.crypto.params does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[26,38] package org.bouncycastle.util.encoders does not exist
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[34,17] cannot find symbol
   [ERROR]   symbol:   class BufferedBlockCipher
   [ERROR]   location: class org.apache.zeppelin.user.Encryptor
   [ERROR] /Users/chengpan/Projects/apache-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Encryptor.java:[35,17] cannot find symbol
   [ERROR]   symbol:   class BufferedBlockCipher
   [ERROR]   location: class org.apache.zeppelin.user.Encryptor
   [ERROR] -> [Help 1]
   [ERROR]
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR]
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   [ERROR]
   [ERROR] After correcting the problems, you can resume the build with the command
   [ERROR]   mvn <args> -rf :zeppelin-zengine
   ```
   
   It works fine after upgrading.
   
   <img width="376" alt="image" src="https://user-images.githubusercontent.com/26535726/204860823-148b6b54-05bb-4b59-9727-5c695a8569c3.png">
   
   
   ### What type of PR is it?
   
   Improvement(maybe)
   
   *Please leave your type of PR only*
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   
   ZEPPELIN-5856
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   
   ### Questions:
   * Does the licenses files need to update? Yes and updated.
   * Is there breaking changes for older versions? No.
   * Does this needs documentation? No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul merged pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4522:
URL: https://github.com/apache/zeppelin/pull/4522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] pan3793 commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4522:
URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333282244

   > Hello, thank you for checking it. BTW, I cannot reproduce this issue on my local machine. could you please let me know how to make an error?
   > 
   > ```
   > [INFO] ------------------------------------------------------------------------
   > [INFO] Reactor Summary for Zeppelin 0.11.0-SNAPSHOT:
   > [INFO]
   > [INFO] Zeppelin ........................................... SUCCESS [  2.850 s]
   > [INFO] Zeppelin: Common ................................... SUCCESS [  2.474 s]
   > [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 19.525 s]
   > [INFO] Zeppelin: Jupyter Support .......................... SUCCESS [  1.359 s]
   > [INFO] Zeppelin: Zengine .................................. SUCCESS [  7.848 s]
   > [INFO] ------------------------------------------------------------------------
   > [INFO] BUILD SUCCESS
   > [INFO] ------------------------------------------------------------------------
   > [INFO] Total time:  35.348 s
   > [INFO] Finished at: 2022-12-01T13:09:32+09:00
   > [INFO] ------------------------------------------------------------------------
   > ➜  zeppelin git:(minor/fix-appveyor-error) ./mvnw clean package -pl zeppelin-zengine -am -DskipTests
   > ```
   
   I use the M1 mac, may be related (not sure), I can not compile the project, I'm going to fix it one by one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4522:
URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333620239

   > I use the M1 mac, may be related (not sure), I can not compile the project, I'm going to fix it one by one
   
   Yep. I also use m1 mac. BTW, I appreciate your interest for Zeppelin. I look forward to seeing you frequently in the community as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] pan3793 commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4522:
URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1336306154

   I didn't figure out why 1.60 does not work on my machine, but I think the upgrading is fine, I guess the failed CI is not related since master branch has the same failure. And the the Maven Central site show 1.60 affected by [CVE-2020-15522](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15522), anyway, we need this upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [zeppelin] jongyoul commented on pull request #4522: [ZEPPELIN-5856] Bump bouncycastle 1.70

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4522:
URL: https://github.com/apache/zeppelin/pull/4522#issuecomment-1333141421

   Hello, thank you for checking it. BTW, I cannot reproduce this issue on my local machine. could you please let me know how to make an error?
   
   ```
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary for Zeppelin 0.11.0-SNAPSHOT:
   [INFO]
   [INFO] Zeppelin ........................................... SUCCESS [  2.850 s]
   [INFO] Zeppelin: Common ................................... SUCCESS [  2.474 s]
   [INFO] Zeppelin: Interpreter .............................. SUCCESS [ 19.525 s]
   [INFO] Zeppelin: Jupyter Support .......................... SUCCESS [  1.359 s]
   [INFO] Zeppelin: Zengine .................................. SUCCESS [  7.848 s]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  35.348 s
   [INFO] Finished at: 2022-12-01T13:09:32+09:00
   [INFO] ------------------------------------------------------------------------
   ➜  zeppelin git:(minor/fix-appveyor-error) ./mvnw clean package -pl zeppelin-zengine -am -DskipTests
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org