You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 11:47:42 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
jorisvandenbossche opened a new pull request #8952:
URL: https://github.com/apache/arrow/pull/8952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-748864021
Revision: b0dd4dbbc8b5f8ca2c89d3f95f002065c249e135
Submitted crossbow builds: [ursa-labs/crossbow @ actions-819](https://github.com/ursa-labs/crossbow/branches/all?query=actions-819)
|Task|Status|
|----|------|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-819-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-819-github-test-conda-python-3.8-pandas-nightly)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747398578
Revision: fc5b3a0d3839212119c148500a59953b89dc5f98
Submitted crossbow builds: [ursa-labs/crossbow @ actions-811](https://github.com/ursa-labs/crossbow/branches/all?query=actions-811)
|Task|Status|
|----|------|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-811-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-811-github-test-conda-python-3.8-pandas-nightly)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747582175
There is still a failure, but a different one now:
```
_________________ TestConvertMetadata.test_mixed_column_names __________________
self = <pyarrow.tests.test_pandas.TestConvertMetadata object at 0x7f8ee85413c0>
def test_mixed_column_names(self):
# mixed type column names are not reconstructed exactly
df = pd.DataFrame({'a': [1, 2], 'b': [3, 4]})
for cols in [['あ', b'a'], [1, '2'], [1, 1.5]]:
df.columns = pd.Index(cols, dtype=object)
# assert that the from_pandas raises the warning
with pytest.warns(UserWarning):
pa.Table.from_pandas(df)
expected = df.copy()
expected.columns = df.columns.astype(str)
with pytest.warns(UserWarning):
_check_pandas_roundtrip(df, expected=expected,
> preserve_index=True)
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/test_pandas.py:422:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/test_pandas.py:102: in _check_pandas_roundtrip
else False))
pandas/_libs/testing.pyx:46: in pandas._libs.testing.assert_almost_equal
???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> ???
E AssertionError: DataFrame.columns are different
E
E DataFrame.columns values are different (50.0 %)
E [left]: Index(['あ', 'a'], dtype='object')
E [right]: Index(['あ', 'b'a''], dtype='object')
pandas/_libs/testing.pyx:161: AssertionError
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747392379
@github-actions crossbow submit test-conda-python-3.7-pandas-master test-conda-python-3.8-pandas-nightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-748863208
@github-actions crossbow submit test-conda-python-3.7-pandas-master test-conda-python-3.8-pandas-nightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747391886
This is rather ugly and brittle (since it relies on the exact place where this method is defined in pandas). But I also can't directly think of a better way to keep the original intent of the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-748883666
OK, all green, so merging this to get the nightly builds passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747399346
https://issues.apache.org/jira/browse/ARROW-10951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #8952: ARROW-10951: [Python][CI] Fix nightly pandas builds (pytest monkeypatch issue)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #8952:
URL: https://github.com/apache/arrow/pull/8952
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org