[GitHub] [spark] sap1ens commented on a change in pull request #28852: [SPARK-30616][SQL] Introduce TTL config option for SQL Metadata Cache

[GitBox <gi...@apache.org>]

sap1ens commented on a change in pull request #28852:
URL: https://github.com/apache/spark/pull/28852#discussion_r442351399



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -835,6 +835,15 @@ object SQLConf {
       .longConf
       .createWithDefault(250 * 1024 * 1024)
 
+  val HIVE_FILESOURCE_PARTITION_FILE_CACHE_TTL =
+    buildConf("spark.sql.hive.filesourcePartitionFileCacheTTL")

Review comment:
       So, `spark.sql.hive.filesourcePartitionFileCacheTTL` simply mirrors the existing `spark.sql.hive.filesourcePartitionFileCacheSize` config. I think it makes sense for consistency, since they're applied to the same cache.
   
   I don't mind dropping `hive`, but in this case it also makes sense to drop it from the `spark.sql.hive.filesourcePartitionFileCacheSize` and it's going to be a backwards-incompatible change.
   
   What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org