You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Narayan Periwal <na...@inmobi.com> on 2015/08/27 13:30:06 UTC
Review Request 37837: FALCON-1416: Add ACL (if missing) during touch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37837/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Currently to keep ACL backward compatible when we submit an entity without ACL tag then falcon automatically adds ACL to the entity definition. The same is done during update also, however it is omitted during touch command
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2
Diff: https://reviews.apache.org/r/37837/diff/
Testing
-------
Done
Thanks,
Narayan Periwal
Re: Review Request 37837: FALCON-1416: Add ACL (if missing) during
touch
Posted by sandeep samudrala <sa...@gmail.com>.
> On Aug. 27, 2015, 6:05 p.m., Balu Vellanki wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java, line 425
> > <https://reviews.apache.org/r/37837/diff/1/?file=1055863#file1055863line425>
> >
> > Shouldn't the entity be decorated with ACL if authorization is enabled, and skip decoration if authorization is disabled?
> >
> > This might be a bug in existing code.
decorateEntityWithACL checks for the same? doesn't it?
- sandeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37837/#review96721
-----------------------------------------------------------
On Aug. 27, 2015, 11:30 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37837/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 11:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently to keep ACL backward compatible when we submit an entity without ACL tag then falcon automatically adds ACL to the entity definition. The same is done during update also, however it is omitted during touch command
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2
>
> Diff: https://reviews.apache.org/r/37837/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37837: FALCON-1416: Add ACL (if missing) during
touch
Posted by Balu Vellanki <bv...@hortonworks.com>.
> On Aug. 27, 2015, 6:05 p.m., Balu Vellanki wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java, line 425
> > <https://reviews.apache.org/r/37837/diff/1/?file=1055863#file1055863line425>
> >
> > Shouldn't the entity be decorated with ACL if authorization is enabled, and skip decoration if authorization is disabled?
> >
> > This might be a bug in existing code.
>
> sandeep samudrala wrote:
> decorateEntityWithACL checks for the same? doesn't it?
This line is in method decorateEntityWithACL
- Balu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37837/#review96721
-----------------------------------------------------------
On Aug. 27, 2015, 11:30 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37837/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 11:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently to keep ACL backward compatible when we submit an entity without ACL tag then falcon automatically adds ACL to the entity definition. The same is done during update also, however it is omitted during touch command
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2
>
> Diff: https://reviews.apache.org/r/37837/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>
Re: Review Request 37837: FALCON-1416: Add ACL (if missing) during
touch
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37837/#review96721
-----------------------------------------------------------
+1 to your changes.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 425)
<https://reviews.apache.org/r/37837/#comment152362>
Shouldn't the entity be decorated with ACL if authorization is enabled, and skip decoration if authorization is disabled?
This might be a bug in existing code.
- Balu Vellanki
On Aug. 27, 2015, 11:30 a.m., Narayan Periwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37837/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 11:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Currently to keep ACL backward compatible when we submit an entity without ACL tag then falcon automatically adds ACL to the entity definition. The same is done during update also, however it is omitted during touch command
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 5b415a2
>
> Diff: https://reviews.apache.org/r/37837/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Narayan Periwal
>
>