[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1169: Refactor schema service

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #1169:
URL: https://github.com/apache/servicecomb-service-center/pull/1169#discussion_r765639767



##########
File path: server/resource/disco/schema_resource.go
##########
@@ -29,50 +29,54 @@ import (
 	"github.com/apache/servicecomb-service-center/pkg/rest"
 	"github.com/apache/servicecomb-service-center/pkg/util"
 	"github.com/apache/servicecomb-service-center/server/config"
-	"github.com/apache/servicecomb-service-center/server/core"
+	discosvc "github.com/apache/servicecomb-service-center/server/service/disco"
 	pb "github.com/go-chassis/cari/discovery"
 )
 
 var errModifySchemaDisabled = errors.New("schema modify is disabled")
 
-type SchemaService struct {
+type SchemaRouter struct {
 	//
 }
 
-func (s *SchemaService) URLPatterns() []rest.Route {
+func (s *SchemaRouter) URLPatterns() []rest.Route {

Review comment:
       应该是Resource

##########
File path: server/rest/controller/v4/v4.go
##########
@@ -28,7 +29,7 @@ func init() {
 func initRouter() {
 	roa.RegisterServant(&MainService{})
 	roa.RegisterServant(&MicroServiceService{})
-	roa.RegisterServant(&SchemaService{})
+	roa.RegisterServant(&disco.SchemaRouter{})

Review comment:
       路径上还是应该有版本号




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org