You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/10 04:15:31 UTC

[GitHub] [rocketmq-client-cpp] codecov-io edited a comment on issue #222: feat(client): add timer to clean off line broker and test case.

codecov-io edited a comment on issue #222: feat(client): add timer to clean off line broker and test case.
URL: https://github.com/apache/rocketmq-client-cpp/pull/222#issuecomment-572495050
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=h1) Report
   > Merging [#222](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/2faaa1fb430c2d4b6b84b3f11d1bb3c9ebc6d1db?src=pr&el=desc) will **increase** coverage by `2.28%`.
   > The diff coverage is `72.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #222      +/-   ##
   ==========================================
   + Coverage   45.53%   47.82%   +2.28%     
   ==========================================
     Files         171      173       +2     
     Lines       10243    10441     +198     
   ==========================================
   + Hits         4664     4993     +329     
   + Misses       5579     5448     -131
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/MQClientManager.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50TWFuYWdlci5jcHA=) | `100% <ø> (ø)` | :arrow_up: |
   | [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `16.14% <0%> (+13.39%)` | :arrow_up: |
   | [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `18.45% <10.34%> (+12%)` | :arrow_up: |
   | [test/src/MQClientFactoryTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-dGVzdC9zcmMvTVFDbGllbnRGYWN0b3J5VGVzdC5jcHA=) | `100% <100%> (ø)` | |
   | [test/src/MQClientAPIImpTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-dGVzdC9zcmMvTVFDbGllbnRBUElJbXBUZXN0LmNwcA==) | `98.11% <98.11%> (ø)` | |
   | [src/common/MQClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9NUUNsaWVudC5jcHA=) | `38.61% <0%> (-0.39%)` | :arrow_down: |
   | [src/producer/DefaultMQProducer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL3Byb2R1Y2VyL0RlZmF1bHRNUVByb2R1Y2VyLmNwcA==) | `5.47% <0%> (-0.02%)` | :arrow_down: |
   | [src/consumer/OffsetStore.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL09mZnNldFN0b3JlLmNwcA==) | `0% <0%> (ø)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=footer). Last update [2faaa1f...720d45a](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services