[GitHub] [superset] prosdev0107 commented on a change in pull request #19122: fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

[GitBox <gi...@apache.org>]

prosdev0107 commented on a change in pull request #19122:
URL: https://github.com/apache/superset/pull/19122#discussion_r830230100



##########
File path: superset-frontend/src/components/ReportModal/index.tsx
##########
@@ -250,9 +251,16 @@ const ReportModal: FunctionComponent<ReportProps> = ({
         await dispatch(addReport(newReportValues as ReportObject));
         onHide();
       } catch (e) {
-        const parsedError = await getClientErrorObject(e);
-        const errorMessage = parsedError.message;
-        onReducerChange(ActionType.error, errorMessage);
+        const { error } = await getClientErrorObject(e);
+        if (error) {

Review comment:
       @diegomedina248 @rusackas 
   
   what is your correct expectation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org