[GitHub] rdblue commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #52: Use the FileIO submodule in Spark writers and readers.
URL: https://github.com/apache/incubator-iceberg/pull/52#discussion_r241587801
 
 

 ##########
 File path: spark/src/main/java/com/netflix/iceberg/spark/source/IcebergSource.java
 ##########
 @@ -89,10 +90,10 @@ public DataSourceReader createReader(DataSourceOptions options) {
           .toUpperCase(Locale.ENGLISH));
     }
 
-    return Optional.of(new Writer(table, lazyConf(), format));
+    return Optional.of(new Writer(table, format, table.operations().io()));
   }
 
-  protected Table findTable(DataSourceOptions options) {
+  protected TableWithTableOperations findTable(DataSourceOptions options) {
 
 Review comment:
   What about adding `io` to the `Table` interface? I'd rather do that since `FileIO` is a public interface. I think that is mostly what HasTableOperations is used for anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services