[GitHub] [dubbo] KamToHung commented on a diff in pull request #12066: Use JsonUtils instead of GsonUtils

["KamToHung (via GitHub)" <gi...@apache.org>]

KamToHung commented on code in PR #12066:
URL: https://github.com/apache/dubbo/pull/12066#discussion_r1164031797


##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java:
##########
@@ -199,7 +199,7 @@ private Object[] getGsonGenericArgs(final Object[] args, Type[] types) {
             }
             String str = args[i].toString();
             try {
-                return GsonUtils.fromJson(str, types[i]);

Review Comment:
   > Some gson related annotation may failed.
   
   I made a mistake.
   Thanks for your guidance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org