You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by ASHUTOSH JAIN <ha...@gmail.com> on 2014/03/19 08:15:32 UTC
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/
-----------------------------------------------------------
(Updated March 19, 2014, 7:15 a.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
For memory more than 2GB, leave 1GB free else use 50% of system memory for the slave
Bugs: MESOS-1105
https://issues.apache.org/jira/browse/MESOS-1105
Repository: mesos-git
Description
-------
using 50% as criteria for mem less than 2GB else leave 1GB for OS.
Diffs
-----
src/slave/containerizer/containerizer.cpp d0a1023
Diff: https://reviews.apache.org/r/19312/diff/
Testing
-------
make check
Thanks,
ASHUTOSH JAIN
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37769
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19312]
All tests passed.
- Mesos ReviewBot
On March 19, 2014, 6:35 p.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 6:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37786
-----------------------------------------------------------
Ship it!
src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/19312/#comment69509>
rm empty line.
- Jiang Yan Xu
On March 19, 2014, 11:35 a.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:35 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by ASHUTOSH JAIN <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37789
-----------------------------------------------------------
src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/19312/#comment69513>
ok
- ASHUTOSH JAIN
On March 19, 2014, 6:35 p.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 6:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37822
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On March 19, 2014, 1:25 p.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 1:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37799
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19312]
All tests passed.
- Mesos ReviewBot
On March 19, 2014, 8:25 p.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/#review37973
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 19, 2014, 8:25 p.m., ASHUTOSH JAIN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19312/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 8:25 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1105
> https://issues.apache.org/jira/browse/MESOS-1105
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> using 50% as criteria for mem less than 2GB else leave 1GB for OS.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp d0a1023
>
> Diff: https://reviews.apache.org/r/19312/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> ASHUTOSH JAIN
>
>
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by ASHUTOSH JAIN <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/
-----------------------------------------------------------
(Updated March 19, 2014, 8:25 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
additional space removed
Bugs: MESOS-1105
https://issues.apache.org/jira/browse/MESOS-1105
Repository: mesos-git
Description
-------
using 50% as criteria for mem less than 2GB else leave 1GB for OS.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp d0a1023
Diff: https://reviews.apache.org/r/19312/diff/
Testing
-------
make check
Thanks,
ASHUTOSH JAIN
Re: Review Request 19312: For memory more than 2GB,
leave 1GB free else use 50% of system memory for the slave
Posted by ASHUTOSH JAIN <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19312/
-----------------------------------------------------------
(Updated March 19, 2014, 6:35 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
new diff according to suggestion by Bmahler
Bugs: MESOS-1105
https://issues.apache.org/jira/browse/MESOS-1105
Repository: mesos-git
Description
-------
using 50% as criteria for mem less than 2GB else leave 1GB for OS.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp d0a1023
Diff: https://reviews.apache.org/r/19312/diff/
Testing
-------
make check
Thanks,
ASHUTOSH JAIN