You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:14:02 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #17868: Add possibility to run DAGs from system tests and see DAGs logs

turbaszek commented on a change in pull request #17868:
URL: https://github.com/apache/airflow/pull/17868#discussion_r699602437



##########
File path: tests/providers/google/suite/operators/test_sheets_system.py
##########
@@ -38,7 +38,13 @@ def helper():
 @pytest.mark.system("google.suite")
 @pytest.mark.credential_file(GCP_GCS_KEY)
 class TestSystemSheetsToGcs(GoogleSystemTest):
+    def setUp(self):
+        super().setUp()
+
     @pytest.mark.usefixtures("helper")
     @provide_gcp_context(GCP_GCS_KEY, scopes=SCOPES)
     def test_run_example_dag(self):
         self.run_dag('example_sheets_gcs', GSUITE_DAG_FOLDER)
+
+    def tearDown(self):
+        super().tearDown()

Review comment:
       I may be missing something here... why we need this? I believe that if a method in a class is not overridden then parent method will be used, won't it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org