You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/05/04 21:50:25 UTC
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17399
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 435 insertions(+), 114 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/17399/1
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17399 )
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
Patch Set 3:
(6 comments)
I did a quick first pass. Overall looks fine, a few questions and nits.
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@928
PS3, Line 928: req.set_comment(data_->comment_.get());
What if this newer client runs against a server of prior version where comments are not yet supported? Should the client get back an error because the server doesn't support setting comments or we are OK with silently dropping the comment information on the floor and sending back all-is-well response?
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@1035
PS3, Line 1035: const string& comment,
nit: the order of the parameters seems a bit odd -- I'd expect the 'comment' to come after 'owner' instead of splitting 'schema' and 'partition_schema'.
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@191
PS3, Line 191: DEFINE_int32
Would -1 be a valid value for this flag? If not, maybe use uint32 type of add a validator?
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@1598
PS3, Line 1598: id
nit: maybe, change this to 'comment'?
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@3055
PS3, Line 3055:
nit: the indent if off
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/master-test.cc@1007
PS3, Line 1007: const char *kTableName
nit: it might be constexpr const char* const kTableName
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 07 May 2021 18:42:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17399 )
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Reviewed-on: http://gerrit.cloudera.org:8080/17399
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 442 insertions(+), 119 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17399
to look at the new patch set (#3).
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 439 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/17399/3
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17399
to look at the new patch set (#2).
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 440 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/17399/2
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17399
to look at the new patch set (#4).
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
KUDU-3164: Add table comment support to Kudu
This patch adds the basic plumbing for table comments,
synchronizing comments with HMS both using the
notification log listener and via tooling, and setting the
comment on CREATE TABLE and ALTER TABLE requests in
the C++ client.
The maximum comment length is 256 characters by default
which aligns with HMS/Apache Impala maximum comment
lengths, but it's configurable with the
max_table_comment_length flag.
Supporting this in the Java and Python clients, and backup
and restore jobs will come in follow on patches.
Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client.proto
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/client/table_creator-internal.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_catalog.h
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/hms_itest-base.h
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/hms_notification_log_listener.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
M src/kudu/tools/tool_action_table.cc
M www/table.mustache
31 files changed, 442 insertions(+), 119 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/17399/4
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17399 )
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@928
PS3, Line 928: req.set_comment(data_->comment_.get());
> I think silently dropping is probably okay given that is how we have handle
Yep, that sounds reasonable: at least for table owner we would have similar behavior, and that didn't seem to be a big deal. I guess we should just document that in release notes.
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@191
PS3, Line 191: DEFINE_int32
> I suppose not. There are a ton of those cases in this file. Perhaps it coul
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 08 May 2021 03:48:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3164: Add table comment support to Kudu
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17399 )
Change subject: KUDU-3164: Add table comment support to Kudu
......................................................................
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@928
PS3, Line 928: req.set_comment(data_->comment_.get());
> What if this newer client runs against a server of prior version where comm
I think silently dropping is probably okay given that is how we have handled new table fields so far and that is the effective behavior for the HMS sync today without the field.
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/client/client.cc@1035
PS3, Line 1035: const KuduSchema& sche
> nit: the order of the parameters seems a bit odd -- I'd expect the 'comment
Done
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@191
PS3, Line 191: DEFINE_int32
> Would -1 be a valid value for this flag? If not, maybe use uint32 type of
I suppose not. There are a ton of those cases in this file. Perhaps it could be a follow up to address adding a bunch of validators for all these flags.
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@1598
PS3, Line 1598: co
> nit: maybe, change this to 'comment'?
Done
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/catalog_manager.cc@3055
PS3, Line 3055: RETU
> nit: the indent if off
Done
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/17399/3/src/kudu/master/master-test.cc@1007
PS3, Line 1007: constexpr const char*
> nit: it might be constexpr const char* const kTableName
Done
--
To view, visit http://gerrit.cloudera.org:8080/17399
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4dbf4018c38fdd0c7f748f4dfc26816f22bd5b2
Gerrit-Change-Number: 17399
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 08 May 2021 03:23:05 +0000
Gerrit-HasComments: Yes