You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/30 23:13:54 UTC
[GitHub] [cloudstack-primate] rhtyd opened a new issue #369: [BUG] Fix translation usage across config and components
rhtyd opened a new issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369
Translations from legacy UI (as of master, after 4.14.0.0 release) were migrated to Primate completely in: https://github.com/apache/cloudstack-primate/pull/368 (PR can be used for reference and audit purpose)
As part of the above PR, the translation keys were standardized and renamed as follows:
- Use a `label.` prefix (same as legacy UI to save devs from learning new conventions)
- If an API parameter is zoneid, then the translation key would be `label.zoneid` for auto-generated widgets/views to work - but this is not completely consistent as there are many custom components
- The keys were renamed, and the map of old-new keys are here: https://github.com/apache/cloudstack-primate/blob/master/src/locales/remove-after-tr-migration/primate-key-renames.json
The task for this effort are:
- Some new components have introduced their own translation keys (see https://github.com/apache/cloudstack-primate/blob/master/src/locales/remove-after-tr-migration/new-keys-list.txt), find and replace usage with keys which are from old translation files and remove these new keys from en.json wherever possible
- Search and fix usage of `$t(...` to use the correct keys as per the current en.json across components (git grep est. ~1400 lines)
- Fix the `title` (~100 occurrences) and `label` (~250 occurrences) in the `config/...` to use the `label.xxx` keys instead of English strings
- Fix English strings use in `:title`, `:label`, `:placeholder`, `message`, `description` with keys from en.json (these list of keywords can be searched using `git grep ... | grep -v locales`)
- For action messages, introduce a new message in configs and use suitable translation key (see en.json for keys with `message...` key names)
- Remove `src/locales/remove-after-tr-migration` after the work is complete
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-647579781
Largely work completed, review/verification would be user-led (with @rhtyd to do one round)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-638043015
Ref
https://github.com/apache/cloudstack-primate/blob/master/src/locales/new-locale-keys.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-637350976
Fixing in #371 and #407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-646204132
docHelp in #435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-636832747
Assigned to @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-636422921
Refer: most migrated with some automation https://github.com/apache/cloudstack-primate/pull/370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-647370031
Only effort remaining is to check and fix the diff between locales/en.json and legacy UI's l10n/en.js
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #369: [BUG] Fix translation usage across config and components and fix doclinks
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #369:
URL: https://github.com/apache/cloudstack-primate/issues/369#issuecomment-637350976
Fixing in #371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org