You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/15 06:54:56 UTC
[GitHub] [hudi] liujinhui1994 commented on a change in pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig
liujinhui1994 commented on a change in pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#discussion_r708891159
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -198,10 +203,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
default:
throw new HoodieMetadataException("Unsupported Metrics Reporter type " + writeConfig.getMetricsReporterType());
}
-
- builder.withMetricsConfig(metricsConfig.build());
}
-
Review comment:
The extra blank lines should be deleted here
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
.withFinalizeWriteParallelism(parallelism);
if (writeConfig.isMetricsOn()) {
- HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
- .withReporterType(writeConfig.getMetricsReporterType().toString())
- .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
- .on(true);
+ builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+ .withReporterType(writeConfig.getMetricsReporterType().toString())
+ .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+ .on(true).build());
switch (writeConfig.getMetricsReporterType()) {
case GRAPHITE:
- metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
- .toGraphiteHost(writeConfig.getGraphiteServerHost())
- .usePrefix(writeConfig.getGraphiteMetricPrefix());
+ builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+ .onGraphitePort(writeConfig.getGraphiteServerPort())
+ .toGraphiteHost(writeConfig.getGraphiteServerHost())
+ .usePrefix(writeConfig.getGraphiteMetricPrefix()).build());
break;
case JMX:
- metricsConfig.onJmxPort(writeConfig.getJmxPort())
- .toJmxHost(writeConfig.getJmxHost());
+ builder.withMetricsJmxConfig(HoodieMetricsJmxConfig.newBuilder()
+ .onJmxPort(writeConfig.getJmxPort())
Review comment:
ok
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
.withFinalizeWriteParallelism(parallelism);
if (writeConfig.isMetricsOn()) {
- HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
- .withReporterType(writeConfig.getMetricsReporterType().toString())
- .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
- .on(true);
+ builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+ .withReporterType(writeConfig.getMetricsReporterType().toString())
+ .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+ .on(true).build());
switch (writeConfig.getMetricsReporterType()) {
case GRAPHITE:
- metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
- .toGraphiteHost(writeConfig.getGraphiteServerHost())
- .usePrefix(writeConfig.getGraphiteMetricPrefix());
+ builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+ .onGraphitePort(writeConfig.getGraphiteServerPort())
Review comment:
ok
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
.withFinalizeWriteParallelism(parallelism);
if (writeConfig.isMetricsOn()) {
- HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
- .withReporterType(writeConfig.getMetricsReporterType().toString())
- .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
- .on(true);
+ builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+ .withReporterType(writeConfig.getMetricsReporterType().toString())
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org