You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/05/29 19:20:00 UTC

[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3154: ARTEMIS-2785 io.netty.util.internal.OutOfDirectMemoryError during uncompress

franz1981 edited a comment on pull request #3154:
URL: https://github.com/apache/activemq-artemis/pull/3154#issuecomment-636121319


   Although it seems like a Netty issue, it's not: the problem is on `ChannelBufferWrapper` because it's using `UnreleasableByteBuf::readBytes(int length)` and wrapping its returned `ByteBuf` (which nature depends on the wrapped `ByteBuf::alloc`) into an `UnreleaeasableByteBuf` that would prevent it to be released and correctly deallocated. 
   
   This PR is both:
   
   - avoiding using an intermediate `readBytes` + `toByteBuffer` to read into a `byte[]` the data
   - removing the wrong method on `ChanneBufferWrapper` given that isn't used anymore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org