You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by "akishichinibu (via GitHub)" <gi...@apache.org> on 2023/02/22 08:44:46 UTC
[GitHub] [zeppelin] akishichinibu opened a new pull request, #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
akishichinibu opened a new pull request, #4568:
URL: https://github.com/apache/zeppelin/pull/4568
### What is this PR for?
Zeppelin Interpreter Support InfluxDB From 1.7.0 To 2.3.0
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5883
### How should this be tested?
* CI passed
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#issuecomment-1521465572
ping @akishichinibu Any JUnit tests to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "akishichinibu (via GitHub)" <gi...@apache.org>.
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
`MockWebServer`is used in the unittests of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "akishichinibu (via GitHub)" <gi...@apache.org>.
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
`MockWebServer` is used in the unittests of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "akishichinibu (via GitHub)" <gi...@apache.org>.
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
The test dependency [okhttp3](https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver) should also be upgrade to `4.7.2` or the tests will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "akishichinibu (via GitHub)" <gi...@apache.org>.
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] akishichinibu commented on a diff in pull request #4568: [ZEPPELIN-5883] Upgrade influxDB client version to 2.3.0
Posted by "akishichinibu (via GitHub)" <gi...@apache.org>.
akishichinibu commented on code in PR #4568:
URL: https://github.com/apache/zeppelin/pull/4568#discussion_r1119639379
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
`MockWebServer` is used in the unit test of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgrade to `4.7.2` or the tests will fail.
##########
influxdb/pom.xml:
##########
@@ -35,8 +35,8 @@
<properties>
<interpreter.name>influxdb</interpreter.name>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <influxdb.client.version>1.7.0</influxdb.client.version>
- <dependency.okhttp3.version>3.13.1</dependency.okhttp3.version>
+ <influxdb.client.version>2.3.0</influxdb.client.version>
+ <dependency.okhttp3.version>4.7.2</dependency.okhttp3.version>
Review Comment:
`MockWebServer` is used in the unit test of `InfluxDBInterpeter`. The test dependency [okhttp3](https://mvnrepository.com/artifact/com.influxdb/influxdb-client-core/6.7.0#:~:text=com.squareup.okhttp3%20%C2%BB%20mockwebserver) should also be upgraded to `4.7.2` or the tests will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org