You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 14:30:54 UTC
[GitHub] [arrow] raulcd opened a new pull request, #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
raulcd opened a new pull request, #13612:
URL: https://github.com/apache/arrow/pull/13612
This PR updated the binary submission job to also generate badges to track the jobs on the newly created PR to track release verification tasks.
I have tested locally with the following:
```
archery crossbow submit \
--no-fetch \
--job-prefix raul-testing-tracking-crossbow-job \
--arrow-version 8.0.0-rc0 \
--arrow-remote "https://github.com/apache/arrow" \
--arrow-branch apache-arrow-8.0.0 \
--group example \
--track-on-pr-titled "WIP: Investigate verify rc linux failures"
```
and the comments generated can be seen on the expected PR: https://github.com/apache/arrow/pull/13478#issuecomment-1184509765
I've had an issue with the submission of jobs due to a CROSSBOW token but this is for the `queue.push()` which hasn't been changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1184531916
https://issues.apache.org/jira/browse/ARROW-16665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1191293410
@kszucs thanks! I did apply your suggestions. Let me know if there's something else pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #13612:
URL: https://github.com/apache/arrow/pull/13612#discussion_r924469833
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -285,6 +285,42 @@ def status(obj, job_name, fetch, task_filters):
report.show(output)
+@crossbow.command()
+@click.option('--arrow-remote', '-r', default=None,
+ help='Set GitHub remote explicitly, which is going to be cloned '
+ 'on the CI services. Note, that no validation happens '
+ 'locally. Examples: https://github.com/apache/arrow or '
+ 'https://github.com/raulcd/arrow.')
+@click.option('--crossbow', '-c', default='ursacomputing/crossbow',
+ help='Crossbow repository on github to use')
+@click.option('--fetch/--no-fetch', default=True,
+ help='Fetch references (branches and tags) from the remote')
+@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN',
+ help='OAuth token to create comments in the arrow repo. '
+ 'Only necessary if --track-on-pr-titled is set.')
+@click.option('--job-name', required=True)
+@click.option('--track-on-pr-titled', default=None,
+ help='Track the job submitted on PR with given title')
+@click.pass_obj
+def report_pr(obj, arrow_remote, crossbow, fetch, github_token, job_name,
+ track_on_pr_titled):
+ arrow = obj['arrow']
+ queue = obj['queue']
+ if fetch:
+ queue.fetch()
+ job = queue.get(job_name)
+
+ if track_on_pr_titled:
Review Comment:
I was thinking that in the future we could add other ways of looking for the PR, like id but you are correct I have made it mandatory as right now it should always be present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1184583592
@kszucs what do you think about this approach? I decided to adapt the existing `archery crossbow submit` command with a flag to track the jobs on a specific PR. It seemed less boilerplate for the task but we might want to split this into a totally separate command or extend the `verify-release-candidate` instead, which is the one that creates the PR in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13612:
URL: https://github.com/apache/arrow/pull/13612#discussion_r924388072
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -285,6 +285,42 @@ def status(obj, job_name, fetch, task_filters):
report.show(output)
+@crossbow.command()
+@click.option('--arrow-remote', '-r', default=None,
+ help='Set GitHub remote explicitly, which is going to be cloned '
+ 'on the CI services. Note, that no validation happens '
+ 'locally. Examples: https://github.com/apache/arrow or '
+ 'https://github.com/raulcd/arrow.')
+@click.option('--crossbow', '-c', default='ursacomputing/crossbow',
+ help='Crossbow repository on github to use')
+@click.option('--fetch/--no-fetch', default=True,
+ help='Fetch references (branches and tags) from the remote')
+@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN',
+ help='OAuth token to create comments in the arrow repo. '
+ 'Only necessary if --track-on-pr-titled is set.')
+@click.option('--job-name', required=True)
+@click.option('--track-on-pr-titled', default=None,
+ help='Track the job submitted on PR with given title')
+@click.pass_obj
+def report_pr(obj, arrow_remote, crossbow, fetch, github_token, job_name,
+ track_on_pr_titled):
+ arrow = obj['arrow']
+ queue = obj['queue']
+ if fetch:
+ queue.fetch()
+ job = queue.get(job_name)
+
+ if track_on_pr_titled:
Review Comment:
Why is it optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1186947105
> @raulcd I think I would prefer having a separate command for that, like a `report_pr()` click command since it would better align with the other report commands.
@kszucs I have created a new `report-pr` command. I've tested the new `report-pr` command via:
```
crossbow_job_prefix="nightly-tests-2022-07-18"
export ARROW_REPOSITORY="apache/arrow"
job_name=$(archery crossbow latest-prefix ${crossbow_job_prefix})
archery crossbow report-pr \
--no-fetch \
--arrow-remote "https://github.com/${ARROW_REPOSITORY}" \
--job-name ${job_name} \
--track-on-pr-titled "WIP: Investigate verify rc linux failures"
```
This is the comment generated:
https://github.com/apache/arrow/pull/13478#issuecomment-1186939479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1193858849
Benchmark runs are scheduled for baseline = ef6049a2ee5673d0944a0b4f70ff9c70e0419a22 and contender = d584b8d7a1c1a4ee1a658bcf9cde9f3a85ae172b. d584b8d7a1c1a4ee1a658bcf9cde9f3a85ae172b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/39112e352ebf4c668af40fee18f78dd4...efcb201c31634817a455dfe78fb7fe86/)
[Failed :arrow_down:0.51% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/72fa46f9a90e406a9c27e236a13ef96b...ddf5d00c33f841a790b3a46220e7be62/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/76630bfc9c074e2987cd3ca6f88e03c6...c5f4409f7563471cb5723075afc83320/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e6b46b018e534d398d4b6bcb48f3306d...f5bd0f7fd4e54b61bd8c82118f0686fa/)
Buildkite builds:
[Failed] [`d584b8d7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1191)
[Failed] [`d584b8d7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1203)
[Finished] [`d584b8d7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1185)
[Finished] [`d584b8d7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1205)
[Failed] [`ef6049a2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1190)
[Finished] [`ef6049a2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1202)
[Finished] [`ef6049a2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1184)
[Finished] [`ef6049a2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1204)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #13612:
URL: https://github.com/apache/arrow/pull/13612#issuecomment-1185542877
@raulcd I think I would prefer having a separate command for that, like a `report_pr()` click command since it would better align with the other report commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs merged pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
kszucs merged PR #13612:
URL: https://github.com/apache/arrow/pull/13612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a diff in pull request #13612: ARROW-16665: [Release] Update binary submit to track binary submission tasks on automatically created PR
Posted by GitBox <gi...@apache.org>.
kszucs commented on code in PR #13612:
URL: https://github.com/apache/arrow/pull/13612#discussion_r924388379
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -285,6 +285,42 @@ def status(obj, job_name, fetch, task_filters):
report.show(output)
+@crossbow.command()
+@click.option('--arrow-remote', '-r', default=None,
+ help='Set GitHub remote explicitly, which is going to be cloned '
+ 'on the CI services. Note, that no validation happens '
+ 'locally. Examples: https://github.com/apache/arrow or '
+ 'https://github.com/raulcd/arrow.')
+@click.option('--crossbow', '-c', default='ursacomputing/crossbow',
+ help='Crossbow repository on github to use')
+@click.option('--fetch/--no-fetch', default=True,
+ help='Fetch references (branches and tags) from the remote')
+@click.option('--github-token', envvar='ARROW_GITHUB_API_TOKEN',
+ help='OAuth token to create comments in the arrow repo. '
+ 'Only necessary if --track-on-pr-titled is set.')
+@click.option('--job-name', required=True)
+@click.option('--track-on-pr-titled', default=None,
Review Comment:
How about a shorter argument name like `--pr-title`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org